mirror of
https://github.com/nvm-sh/nvm.git
synced 2026-07-19 05:18:22 +08:00
The two `v0.40.0` + `nvmrc` jobs fail by design (https://github.com/nvm-sh/nvm/issues/3405), but job-level `continue-on-error` still displays them as failures on every run, which reads like the contributor broke something. Tolerate failure only in the steps that exercise the bug, scoped to that matrix combination, and add a final step that fails the job when the expected failure did not happen - so those jobs are green exactly when v0.40.0 misbehaves as documented, and turn red as a signal to remove this handling if v0.40.0 ever starts passing. This also restores strict failure semantics to the passing `v0.40.0` + `no nvmrc` jobs, which the job-level `continue-on-error` was needlessly masking.
136 lines
4.9 KiB
YAML
136 lines
4.9 KiB
YAML
name: 'Tests: nvm install with set -e'
|
|
|
|
on:
|
|
pull_request:
|
|
push:
|
|
workflow_dispatch:
|
|
inputs:
|
|
ref:
|
|
description: 'git ref to use'
|
|
required: false
|
|
default: 'HEAD'
|
|
|
|
permissions:
|
|
contents: read
|
|
|
|
jobs:
|
|
matrix:
|
|
permissions:
|
|
contents: read
|
|
runs-on: ubuntu-latest
|
|
outputs:
|
|
matrix: ${{ steps.matrix.outputs.matrix }}
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
with:
|
|
fetch-depth: 0
|
|
- id: matrix
|
|
run: |
|
|
if [ "${{ github.event_name }}" == "workflow_dispatch" ] && [ -n "${{ github.event.inputs.ref }}" ]; then
|
|
echo "matrix=\"[\"${{ github.event.inputs.ref }}\"]\"" >> $GITHUB_OUTPUT
|
|
else
|
|
TAGS="$((echo "HEAD" && git tag --sort=-v:refname --merged HEAD --format='%(refname:strip=2) %(creatordate:short)' | grep '^v' | while read tag date; do
|
|
if [ "$(uname)" == "Darwin" ]; then
|
|
timestamp=$(date -j -f "%Y-%m-%d" "$date" +%s)
|
|
threshold=$(date -j -v-4y +%s)
|
|
else
|
|
timestamp=$(date -d "$date" +%s)
|
|
threshold=$(date -d "4 years ago" +%s)
|
|
fi
|
|
if [ $timestamp -ge $threshold ]; then echo "$tag"; fi
|
|
done) | xargs)"
|
|
echo $TAGS
|
|
TAGS_JSON=$(printf "%s\n" $TAGS | jq -R . | jq -sc .)
|
|
echo "matrix=${TAGS_JSON}" >> $GITHUB_OUTPUT
|
|
fi
|
|
|
|
test:
|
|
permissions:
|
|
contents: read
|
|
needs: [matrix]
|
|
runs-on: ubuntu-latest
|
|
strategy:
|
|
fail-fast: false
|
|
matrix:
|
|
ref: ${{ fromJson(needs.matrix.outputs.matrix) }}
|
|
has-nvmrc:
|
|
- 'no nvmrc'
|
|
- 'nvmrc'
|
|
shell-level:
|
|
- 1 shlvl
|
|
- 2 shlvls
|
|
|
|
steps:
|
|
- uses: actions/checkout@v6
|
|
- name: resolve HEAD to sha
|
|
run: |
|
|
if [ '${{ matrix.ref }}' = 'HEAD' ]; then
|
|
REF="$(git rev-parse HEAD)"
|
|
else
|
|
REF="${{ matrix.ref }}"
|
|
fi
|
|
echo "resolved ref: ${REF}"
|
|
echo "ref="$REF"" >> $GITHUB_ENV
|
|
- run: echo $- # which options are set
|
|
- run: echo node > .nvmrc
|
|
if: ${{ matrix.has-nvmrc == 'nvmrc' }}
|
|
- run: curl -I --compressed -v https://nodejs.org/dist/
|
|
- name: 'install nvm'
|
|
run: |
|
|
set -e
|
|
export NVM_INSTALL_VERSION="${ref}"
|
|
curl -o- "https://raw.githubusercontent.com/nvm-sh/nvm/${ref}/install.sh" | bash
|
|
# v0.40.0 with an .nvmrc present is expected to fail (https://github.com/nvm-sh/nvm/issues/3405):
|
|
# the steps below tolerate failure for that combination, and the final step
|
|
# turns the job red only if the expected failure did NOT happen.
|
|
- name: nvm --version
|
|
id: nvm-version
|
|
continue-on-error: ${{ matrix.ref == 'v0.40.0' && matrix.has-nvmrc == 'nvmrc' }}
|
|
run: |
|
|
set +e
|
|
. $NVM_DIR/nvm.sh && nvm --version
|
|
- name: nvm install in 1 shell level, ${{ matrix.has-nvmrc }}
|
|
id: install-1
|
|
if: ${{ matrix.shell-level == '1 shlvl' }}
|
|
continue-on-error: ${{ matrix.ref == 'v0.40.0' && matrix.has-nvmrc == 'nvmrc' }}
|
|
run: |
|
|
set -ex
|
|
. $NVM_DIR/nvm.sh
|
|
echo nvm.sh sourced
|
|
nvm --version
|
|
if [ '${{ matrix.has-nvmrc }}' == 'nvmrc' ]; then
|
|
nvm install
|
|
fi
|
|
- name: nvm install in 2 shell levels, ${{ matrix.has-nvmrc }}
|
|
id: install-2
|
|
if: ${{ matrix.shell-level == '2 shlvls' }}
|
|
continue-on-error: ${{ matrix.ref == 'v0.40.0' && matrix.has-nvmrc == 'nvmrc' }}
|
|
run: |
|
|
if [ '${{ matrix.has-nvmrc }}' == 'nvmrc' ]; then
|
|
bash -c "set -ex && . $NVM_DIR/nvm.sh && echo nvm.sh sourced && nvm --version && nvm install"
|
|
else
|
|
bash -c "set -ex && . $NVM_DIR/nvm.sh && echo nvm.sh sourced && nvm --version"
|
|
fi
|
|
- name: 'confirm the expected failure happened (v0.40.0 + nvmrc)'
|
|
if: ${{ matrix.ref == 'v0.40.0' && matrix.has-nvmrc == 'nvmrc' }}
|
|
env:
|
|
SOURCE_OUTCOME: ${{ steps.nvm-version.outcome }}
|
|
INSTALL_1_OUTCOME: ${{ steps.install-1.outcome }}
|
|
INSTALL_2_OUTCOME: ${{ steps.install-2.outcome }}
|
|
run: |
|
|
echo "nvm --version: ${SOURCE_OUTCOME}; install (1 shlvl): ${INSTALL_1_OUTCOME}; install (2 shlvls): ${INSTALL_2_OUTCOME}"
|
|
if [ "${SOURCE_OUTCOME}" = 'failure' ] || [ "${INSTALL_1_OUTCOME}" = 'failure' ] || [ "${INSTALL_2_OUTCOME}" = 'failure' ]; then
|
|
echo 'v0.40.0 failed as expected: https://github.com/nvm-sh/nvm/issues/3405'
|
|
else
|
|
echo '::error::v0.40.0 with an .nvmrc was expected to fail (https://github.com/nvm-sh/nvm/issues/3405), but every step succeeded. If v0.40.0 somehow works now, remove the expected-failure handling from this workflow.'
|
|
exit 1
|
|
fi
|
|
|
|
finisher:
|
|
permissions:
|
|
contents: none
|
|
runs-on: ubuntu-latest
|
|
needs: [test]
|
|
steps:
|
|
- run: true
|