Commit Graph
5 Commits
Author SHA1 Message Date
Jordan Harband 59cf9a4ef6 [actions] nvm-install-test: turn the expected v0.40.0 failures green
The two `v0.40.0` + `nvmrc` jobs fail by design (https://github.com/nvm-sh/nvm/issues/3405),
but job-level `continue-on-error` still displays them as failures on every run,
which reads like the contributor broke something.
Tolerate failure only in the steps that exercise the bug, scoped to that matrix combination,
and add a final step that fails the job when the expected failure did not happen -
so those jobs are green exactly when v0.40.0 misbehaves as documented,
and turn red as a signal to remove this handling if v0.40.0 ever starts passing.
This also restores strict failure semantics to the passing `v0.40.0` + `no nvmrc` jobs,
which the job-level `continue-on-error` was needlessly masking.
2026-07-09 17:01:32 -07:00
Jordan Harband 16f6ddc3d5 [actions] set per-job permissions in the nvm install workflow
CodeQL (actions/missing-workflow-permissions)
flagged the matrix, test, and finisher jobs of nvm-install-test.yml for not declaring permissions.
Every other test workflow already sets least-privilege permissions per job; add them here to match:
`contents: read` for the matrix and test jobs, `contents: none` for the no-op finisher.
2026-06-03 14:09:02 -07:00
Jordan Harband 242d997da5 [actions] add permissions to GHA workflow 2026-01-29 13:08:52 -08:00
Padraic SlatteryandJordan Harband 34d6d5d6fe [actions] update outdated GitHub Actions versions 2026-01-19 17:39:42 +01:00
Jordan Harband c31a867c46 [Fix] --save: avoid a conflict with set -e
Fixes #3405.
2024-08-10 15:52:24 +12:00