2492 Commits

This Branch

This Branch

All Branches

Author	SHA1	Message	Date
Shuyun Yang	13eee46e7d	[Fix] nvm_ls_cached: match dots in the version literally, and ignore a trailing dot ... The pattern reached `grep` as a regex, so its dots matched any character: `20.1.1` also matched a cached `v20.111.1`, which `nvm install --offline 20.1.1` could then pick as the newest match. A trailing dot, as in `20.1.`, likewise matched `v20.10.0` but not `v20.1.x`. A bare `v`, `iojs-`, or `iojs-v` now matches every cached node or io.js version respectively.	2026-10-27 20:08:55 -07:00
NUAAwqyandCodex	f0d372b01b	[Fix] install.sh: nvm_check_global_modules: don't run a Windows npm under WSL ... Under WSL, `PATH` can include a Windows Node install, so `command -v npm` can find its `npm` shell shim, which then failed against Windows paths. That npm is not a system node that nvm would shadow, so under WSL, skip an npm that has an `npm.cmd` beside it: both the Node installer and npm's own shims put one there. Outside WSL (eg, Git Bash or Cygwin), a Windows npm is the system node, so the warning is kept. Fixes #3700. Signed-off-by: NUAAwqy <146524024+NUAAwqy@users.noreply.github.com> Co-Authored-By: Codex <noreply@openai.com>	2026-10-27 16:28:52 -07:00
Jordan Harband	3fda4d5542	[New] select versions by category: alpha, lts, non-lts, iojs; exclude alphas by default ... Node 27 and later publish Alpha prereleases, like `v27.0.0-alpha.1.0.0`, in the main `index.tab`, so `nvm install node` or `nvm install 27` would otherwise pick one. Every version is in exactly one category: `alpha` and `lts` or `non-lts` (by index.tab's LTS column) on the node mirror, and `iojs` on the io.js mirror. Commands select from every category but `alpha`, unless `$NVM_ONLY` lists others, and every command that selects or lists versions takes `--only=<categories>` to override both; an exact alpha needs `alpha` selected, like any other. An LTS selection, like `--lts` or an `lts/` version, can't combine with an `--only=` that excludes `lts`. Telling installed `lts` and `non-lts` versions apart uses the recorded LTS status, and fails rather than guess without it. `nvm alias` also stores `--only=`, so `nvm alias default --only=alpha node` makes the latest installed alpha the default, including in a new shell.	2026-10-21 14:09:18 -07:00
Jordan Harband	11df5ed6f1	[Perf] nvm_is_installed_exact_version: also take the fast path for an exact prerelease ... An installed prerelease, like `v24.0.0-rc.1`, now resolves to itself without the `nvm_ls` pipeline, as releases already do.	2026-10-21 13:09:25 -07:00
Jordan Harband	fe2900d176	[New] nvm alias: store --lts and --lts=<name> ... `nvm alias default --lts node` writes `--lts node` to the alias file, so it resolves to the latest installed LTS version, using each version's recorded LTS status; `--lts=<name>` limits it to one LTS line. The flags of the outermost alias apply when one alias points at another, an alias with a flag this version of nvm doesn't recognize resolves to nothing, rather than ignoring the flag, and `nvm uninstall` also removes aliases with flags that point at the uninstalled version. A new shell never downloads index.tab, so it explains a default alias that needs LTS status that isn't recorded yet.	2026-10-21 12:57:19 -07:00
Jordan Harband	e5f1288b40	[New] record every node version's LTS status ... Each download of node's `index.tab` now merges every version's LTS codename, or `-`, into `$NVM_DIR/.lts-status`, keeping versions that download doesn't list, so the status of an installed version is known, and refreshed on every remote connection. Only an index that includes LTS versions can start the record, so a nightly or release candidate mirror can't, and `nvm_ensure_lts_status` downloads it once for versions installed before it was recorded. `update_test_mocks.sh` writes the record of its `index.tab` mock to `nodejs.org-dist-lts-status.txt`.	2026-10-21 12:52:04 -07:00
Jordan Harband	4007c0d062	[Tests] bash_completion: don't let zsh's compinit wait for an answer ... On runners where zsh considers a completion directory insecure, `compinit` asks whether to use it, and on the test's terminal waited for an answer forever, which hung every Ubuntu `fast` job. The test now sets `ZSH_DISABLE_COMPFIX`, which `bash_completion` already honors, and gives zsh no stdin.	2026-10-26 11:11:53 -07:00
Jordan Harband	139ed9ccc6	[Fix] nvm: ignore option variables set by the caller ... In dash, and in bash for a variable assigned in the command's own prefix (like `PATTERN=x nvm ls`), `local` keeps the outer value, so a variable a subcommand only sets conditionally, like `PATTERN`, `NVM_LTS`, `LTS`, or `VERSION`, could come from the caller, replacing the version argument, applying an LTS filter that was never requested, or making `nvm use`, without a version or an .nvmrc, use the caller's `VERSION`. Each such local is now initialized where it is declared.	2026-10-21 12:48:18 -07:00
Jordan Harband	6a085bc8b4	[Fix] nvm reinstall-packages: don't print VERSION='' in zsh ... `nvm` already declares `VERSION` local, and declaring an existing local again makes zsh print it.	2026-10-21 12:47:13 -07:00
Jordan Harband	fe017ae9bd	[Fix] nvm_alias, nvm_ls_remote_index_tab, nvm use: return the exit code of a failed check ... `if ! cmd; then return $?` returns the status of the negation, which is 0, so an uppercase LTS name, or an unusable installed version, was reported but still exited successfully.	2026-10-21 12:46:19 -07:00
Jordan Harband	fd23eb2037	[Fix] nvm_print_versions: don't mark N/A as installed ... With nothing installed, `nvm_ls` prints `N/A`, which then counted as an installed version, so `nvm ls` and an unmatched `nvm ls-remote` printed `N/A *`.	2026-10-21 13:52:16 -07:00
Jordan Harband	6cef0edd18	[Fix] nvm_ls: no blank line before system when nothing is installed ... `nvm ls` then printed an empty row ahead of the system version.	2026-10-21 12:44:44 -07:00
Jordan Harband	d65637f2e8	[Fix] nvm_print_versions: widen the version column for long versions ... Versions longer than 15 characters, like nightlies and release candidates, overflowed the fixed-width column, so `nvm ls` and `nvm ls-remote` misaligned them; the column now also fits the `->` before the current version.	2026-10-21 12:44:19 -07:00
Jordan Harband	f58d43f4d5	[Fix] nvm_ls: match a prerelease only up to a . ... A prerelease pattern matched any installed version containing it, so `nvm use v24.0.0-rc.1` could pick `v24.0.0-rc.10`, and a partial prerelease like `v24.0.0-rc` matched nothing. An installed exact prerelease now resolves to itself, and a partial one matches only versions that continue with a `.`.	2026-10-21 12:43:37 -07:00
Jordan Harband	aed19eb997	[Fix] nvm_ls: list every installed prerelease, in semver order ... `sort -u` keyed only on X.Y.Z treated prereleases of a release, and the release itself, as duplicates, so `nvm ls` hid all but one of them, and which one survived depended on directory order. `nvm_sort_versions` orders them by semver precedence instead, so `v24.0.0-rc.2` sorts before `v24.0.0-rc.10`, and both before `v24.0.0`.	2026-10-21 12:40:42 -07:00
Jordan Harband	79214249bb	[Fix] nvm uninstall: only remove aliases that point at the uninstalled version ... Matching alias files by substring also removed aliases to longer versions, so uninstalling v20.1.1 deleted an alias to v20.1.10. Each alias's target is now read the way `nvm_alias` reads it, ignoring comments, and in zsh an empty alias directory no longer errors with "no matches found".	2026-10-21 12:39:28 -07:00
Jordan Harband	43a2abbfd5	[Fix] nvm_ls_cached: only match whole version numbers ... An unanchored `grep` let a pattern match any cached version containing it, so `nvm install --offline 20.1.1` could install a cached v20.1.10, and `nvm install --offline iojs`, whose pattern is empty, matched every cached node version.	2026-10-21 12:39:00 -07:00
Jordan Harband	e7363fa669	[actions] tests-alpine: time out jobs well before GitHub's 6-hour limit ... A hung `fast` job, like the busybox `sh` lanes in `nvm debug`, otherwise ran for 6 hours before being cancelled. `fast` jobs take a few minutes and `musl-binary` jobs under one, so they now time out after 15 and 10.	2026-10-25 11:43:54 -07:00
Jordan Harband	898124fd60	[Fix] nvm debug: don't let the shell read stdin when asked for its version ... busybox's shells have no `--version`, and start an interactive shell instead, so with `$SHELL` set to busybox `sh` on a terminal, `nvm debug` waited for input forever, which hung the alpine `sh` CI lanes in the "mirror URL credentials are masked in output" test. Like the other busybox tools, its version now comes from `--help`, and every shell is given no stdin to read.	2026-10-25 11:42:45 -07:00
Jordan Harband	e780535240	[Fix] nvm_download: with GNU Wget, follow only same-origin redirects when sending $NVM_AUTH_HEADER ... curl 7.58.0 and later drop a custom Authorization header when a redirect leads to another host, but wget sends `--header` along to every redirect target, so on a machine without curl, a mirror that redirected elsewhere handed the credential to that other host. When a header is sent with GNU Wget, run it with `--max-redirect=0`. When it then exits with 8 (an HTTP error, which includes a redirect it did not follow), read the `Location` with one more request, and re-request it only if it keeps the same scheme, host, and port, up to 20 times. A redirect to another origin, including a downgrade to `http`, fails with exit code 8 and an error that names the URL nvm requested and suggests curl. `--max-redirect` is not a BusyBox wget option, so other wgets are invoked as before; the README says so Discovered by Anthropic's OSS Scanner, as ANT-2026-PKUZHTT3; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	e3aa232901	[Fix] nvm_download: only send $NVM_AUTH_HEADER to URLs under a mirror it applies to ... The header was added to every download, whatever the host. With only `$NVM_NODEJS_ORG_MIRROR` set, a private mirror's credential therefore also went to the default `https://iojs.org/dist` (eg, from `nvm ls-remote`), and with only `$NVM_IOJS_ORG_MIRROR` set, to `https://nodejs.org/dist`; it also went to `npmjs.org` when installing an old npm. Add `nvm_auth_header_applies_to`, which uses `nvm_get_mirror` and accepts a URL only when it is under a mirror, compared literally, with a `/` after the mirror's prefix. When exactly one of the two mirror variables is set, the header belongs to that mirror alone; when both or neither are set, both mirrors (including the defaults, when neither is) still receive it, so the documented example keeps working. An invalid mirror matches nothing, and no empty `Authorization:` header is sent when sanitizing leaves nothing Discovered by Anthropic's OSS Scanner, as ANT-2026-YPW87EDH; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	6bbbf3e8d3	[Tests] nvm_download: point the httpbin Authorization check at a configured mirror ... The httpbin check sends `$NVM_AUTH_HEADER` to `http://127.0.0.1/bearer` without configuring a mirror. Set `$NVM_NODEJS_ORG_MIRROR` to that host, as a real user of the header would, so the check keeps exercising the header once it is only sent to URLs under a mirror Discovered by Anthropic's OSS Scanner, as ANT-2026-YPW87EDH; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	00217de1e1	[Fix] install.sh: don't let a git repository in the current directory affect git ls-remote ... `install_nvm_from_git` checked whether `$NVM_INSTALL_VERSION` is a ref with a bare `git ls-remote`, which discovers and loads the config of whatever repository contains the current directory. That repository's `url.*.insteadOf` and `core.sshCommand` could then redirect or hijack the check, unlike every other git command in the function, which already passes `--git-dir="$INSTALL_DIR"/.git`. Pass `--git-dir` here too; `ls-remote` works even when that directory does not exist yet, as on a fresh install Discovered by Anthropic's OSS Scanner, as ANT-2026-JS4YHKRK; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	0333df56ca	[Robustness] install.sh, nvm uninstall: pass the version to grep with -e ... `install_nvm_from_git` passed `$NVM_INSTALL_VERSION` to grep as a bare argument, and `nvm uninstall` did the same with the resolved version when looking for aliases that point to it, so a value starting with `-` would have been parsed as grep options rather than as the pattern. Neither value crosses a trust boundary (the first is the user's own environment variable, and the second is an already-installed version, which never starts with `-`), but every grep that receives a version should put it after `-e`, which POSIX specifies and which nvm.sh already uses elsewhere Discovered by Anthropic's OSS Scanner, alongside vulnerability ANT-2026-EN9DM7WC; this change is not itself a vulnerability fix.	2026-10-23 08:53:59 -07:00
Jordan Harband	cbd8f8e920	[Fix] nvm_remote_versions: only consult io.js's version list for majors 1 through 3 ... io.js only released v1 through v3, but its version list was downloaded and searched for every pattern, including ones like `0.12` or `20` that can only ever match node versions. Besides the needless index.tab download on every such `nvm install`, io.js's "no match" status was returned even when node had matches, so `nvm ls-remote 20` printed node's versions and then exited 3. Patterns whose major is 0 or 4+ now only consult node's list, so `nvm ls-remote` exits 0 for them when node has matching versions. The listed and resolved versions are unchanged Discovered by Anthropic's OSS Scanner, as ANT-2026-AKH0HYWD; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	59e008fd62	[Fix] nvm_remote_versions: place io.js versions by major version, not at the literal v4.0.0 ... io.js versions were inserted into node's version list immediately before the `v4.0.0` line. Whenever node's filtered list did not contain that exact line, every io.js version was appended after all node versions, including newer ones, so `nvm_remote_version`'s `tail -1` could pick an io.js version over the latest matching node version. Node's list is sorted, so it is now split at the first version with a nonzero major, which keeps io.js versions between node v0.x and node v4+ regardless of which node versions the pattern matched Discovered by Anthropic's OSS Scanner, as ANT-2026-AKH0HYWD; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	35d6e5a000	[Fix] nvm.sh: detect NVM_DIR without $0/$_; fall back to the default install location instead of the working directory ... When `nvm.sh` is sourced with `NVM_DIR` unset, it derived `NVM_DIR` from the sourced file in bash (via `BASH_SOURCE`), and otherwise from `dirname "${_:-$0}"`. In shells that do not set `BASH_SOURCE` (dash, sh, ksh, and zsh under `emulate sh` or without `FUNCTION_ARGZERO`), `$0` is the shell's or the calling script's name and `$_` is whatever was inherited, so `NVM_DIR` became an unrelated directory: for `sh -c '. ~/.nvm/nvm.sh'`, as run by `system(3)` or `popen(3)`, that is the working directory, whose `alias/default` and `versions/` nvm then used, and from which `nvm cache clear` and friends would operate. Detection now uses only reliable sources: `BASH_SOURCE` in bash, `${(%):-%x}` in zsh (which names the sourced file regardless of options), and `${.sh.file}` in ksh93 (probed in a subshell first, since other shells with `KSH_VERSION` reject the syntax) A detected source that is not a regular file (eg, `/dev/fd/63` from `. <(…)`) is ignored. Otherwise, nvm uses the default install location that `install.sh` uses (`$XDG_CONFIG_HOME/nvm`, else `~/.nvm`) when it contains `nvm.sh`, and if not, it prints an error asking for `NVM_DIR` to be set and returns 1, instead of guessing. Setups that export `NVM_DIR` before sourcing `nvm.sh`, as `install.sh` and the README do, are unaffected Discovered by Anthropic's OSS Scanner, as ANT-2026-8RIT0MGO; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	c07e8722a1	[Tests] nvm_get_arch_unofficial: set NVM_DIR when sourcing nvm.sh in the chroots ... The chroot checks source `nvm.sh` from `/bin/sh` without `NVM_DIR`, so nvm has to guess it: today from `dirname "$0"`, which is `/bin` here. That guess is incidental to what the test checks (architecture detection), so set `NVM_DIR` explicitly to the directory the chroot's `nvm.sh` lives in, as the README instructs Discovered by Anthropic's OSS Scanner, as ANT-2026-8RIT0MGO; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	3649f2b9a7	[meta] Makefile: default NVM_DIR to the checkout when it is not set ... The test suites source `nvm.sh` without setting `NVM_DIR` unless the caller exports it, which locally (where `NVM_*` variables are unset first) and in the `urchin tests` workflow it is not. bash and zsh then detect the checkout from the sourced file, but sh and dash have no way to locate a sourced file, so they fell back to `dirname "$0"`, which happened to be the test's own directory. The `test-<shell>` targets now export `NVM_DIR` as the checkout when it is still unset, so every shell runs the suites against the same `NVM_DIR`, and an explicitly provided `NVM_DIR` is kept Discovered by Anthropic's OSS Scanner, as ANT-2026-8RIT0MGO; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	8610e1578d	[Fix] nvm_process_nvmrc_content: reject control characters ... An `.nvmrc` line containing a control character (eg, an escape, a bell, or a carriage return in the middle of the version) was accepted as-is, so the raw bytes were passed along as the version and printed verbatim in the "Found '…' with version <…>" and "N/A: version … is not yet installed" messages, garbling the terminal output. Any line that still contains a control character other than a tab, after comments and leading and trailing white space are removed, now makes the file invalid. CRLF line endings keep working, since the trailing carriage return is trimmed as white space before the check. The "non-commented content parsed" part of the invalid `.nvmrc` message now shows each control character (other than tabs and newlines) as `?`, so it prints as plain text Discovered by Anthropic's OSS Scanner, as ANT-2026-R3FR49Z7; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	4a1f7d2875	[Fix] nvm_download_artifact, nvm debug: mask credentials in mirror URLs when printing them ... `nvm_get_mirror` accepts `user:password@` in `$NVM_NODEJS_ORG_MIRROR` and `$NVM_IOJS_ORG_MIRROR`, but `nvm_download_artifact` printed the full tarball URL in its "Downloading", "download from ... failed", and "HTTP 404 at URL" messages, and `nvm debug` printed both mirror variables as-is, so the credentials showed up in terminal output and build logs. Add `nvm_sanitize_url`, which replaces the userinfo part of any URL with `***@`, and use it in those messages. The download itself still uses the full URL, so authenticating to the mirror keeps working. The README now notes that `$NVM_AUTH_HEADER` is the recommended way to authenticate to a mirror Discovered by Anthropic's OSS Scanner, as ANT-2026-X03SZ7C6; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:59 -07:00
Jordan Harband	37c578d973	[Fix] nvm_install_binary, nvm_install_source: only use a tarball that nvm_download_artifact put in the cache ... `nvm_install_binary` and `nvm_install_source` took the tarball path from the last line of `nvm_download_artifact`'s output via `| tail -1`. That pipeline's exit status is `tail`'s, so a failed download went unnoticed, and the downloader's own stdout was not separated from the path: anything it printed (eg, from a curl `write-out` setting) could be the last line. If that line happened to name an existing file relative to the current directory, it was extracted and installed as if it were the downloaded tarball, instead of the install failing. `nvm_download_artifact` now sends the downloader's output to stderr, so its stdout is only ever the tarball path. Both install functions capture its output directly and honor its exit status, and accept the result only if it is an existing file inside nvm's cache directory, via a new `nvm_is_cached_artifact` helper Discovered by Anthropic's OSS Scanner, as ANT-2026-DESJ2ESZ; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:58 -07:00
Jordan Harband	c8a2a81f92	[Fix] nvm_download, nvm_get_latest, install.sh: pass -q to curl first, so .curlrc is ignored again ... curl only skips reading `.curlrc` when `-q` is its very first argument; anywhere else, the config file has already been read by the time `-q` is seen. a4f89c62 added `-q` to every curl call so that a user's `.curlrc` would not affect nvm, but 6a3b1dd2 (v0.33.2) put `--compressed` in front of it everywhere. bd090ef7 (v0.40.0) moved it back to the front in `nvm.sh`'s `nvm_download`, and then 6d870d18 (v0.40.5) began building those arguments with `set --`, prepending `--compressed` after `-q`, so whenever curl supports compression, `-q` was second again. `nvm_get_latest` and `install.sh`'s `nvm_download` have passed `--compressed` before `-q` since v0.33.2. Pass `-q` first in all three places. Settings in a user's `.curlrc` (such as a proxy, CA bundle, or `write-out`) no longer apply to nvm's own curl calls, as was intended, and as in v0.40.0 through v0.40.4 for `nvm_download`; the corresponding environment variables (eg, `https_proxy`, `CURL_CA_BUNDLE`) still apply. The existing `nvm_get_latest` test pinned the old argument order, so its expectation is updated Discovered by Anthropic's OSS Scanner, as ANT-2026-DESJ2ESZ; the scanner reported it as a vulnerability, but it is not one.	2026-10-23 08:53:58 -07:00
Jordan Harband	013b291d36	[meta] release-notes.sh: replace control characters in commit subjects ... Commit subjects were printed as-is, so escape sequences, carriage returns, and other control characters in a subject reached the terminal during `make release-notes` and `make release`, where they could hide or rewrite lines of the notes being reviewed, and were then written verbatim into the bump commit and the release tag. A tab in a subject also corrupted the tab-separated intermediate file. Subjects are now filtered as they are read from `git log`, replacing C0 controls, DEL, and UTF-8-encoded C1 controls with `?`. They are replaced rather than removed so that the bytes on either side cannot join into a new control character, and so the change stays visible in the notes. The section `grep` now matches bytes, because in a UTF-8 locale GNU grep stops printing matches at a line that is not valid UTF-8, which silently dropped bullets. Lowercasing a subject to find its category now works on bytes too, because in a UTF-8 locale BSD `tr` stops at a byte that is not valid UTF-8. Discovered by Anthropic's OSS Scanner, as bug ANT-2026-INF3JLG6; the scanner correctly classified it as not a vulnerability.	2026-10-23 08:53:58 -07:00
Jordan Harband	d639676bb0	[Fix] nvm_is_version_installed: fail when nvm_version_path fails ... Since 072622c7, `nvm_version_path` rejects a version with a `..` path component, printing nothing and returning 3. `nvm_is_version_installed` ignored that status and appended `/bin/node` to the empty output, so for such a version (eg, `v/../x` in an `.nvmrc`) it checked `/bin/node`, and reported the version as installed whenever a system node lived there. `nvm use` then put `/bin` in place of the active version on `PATH`, and `nvm which` printed `/bin/node`. Propagate `nvm_version_path`'s failure, so such a version is never installed Discovered by Anthropic's OSS Scanner, as bug ANT-2026-O1QONH45; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	39fca6c905	[Fix] nvm use, nvm-exec: stop option parsing at -- ... `nvm use` treated `--` as a no-op and kept parsing options after it, so `nvm use -- -w` enabled `--save`, fell back to `.nvmrc`, and rewrote it with the resolved version; `--delete-prefix` and unknown `--*` arguments after `--` were likewise acted on or silently dropped. Now the argument after `--` is taken as the version and option parsing stops there; a lone `--` still falls back to `.nvmrc`. `nvm-exec` now passes `NODE_VERSION` after `--`, so its value is always treated as a version and never as an option Discovered by Anthropic's OSS Scanner, as bug ANT-2026-4RO8S9N0; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	020503b536	[Fix] nvm install: validate an inherited NVM_MAKE_JOBS like -j ... A job count given with `-j` is checked by `nvm_get_make_jobs`, which rejects anything but a natural number and falls back to the detected core count. A non-empty `NVM_MAKE_JOBS` already in the environment skipped that check entirely, and was passed as-is to `make -j`, where a value like `V=1` or `-f/dev/null` is taken as a separate `make` argument. Now an inherited value that is not a natural number gets the same error and fallback as an invalid `-j`; a valid one is still used, and an empty one still triggers detection silently Discovered by Anthropic's OSS Scanner, as bug ANT-2026-SYLQD6PZ; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	813b5f6dcc	[Fix] nvm_is_natural_num: reject anything but digits ... `[ "$1" -eq "$1" ]` accepts more than a natural number: a leading `+`, and leading or trailing whitespace, and in ksh it evaluates its operands as arithmetic expressions, so words like `install` and expressions like `1+1` or `V=1` pass too. Values with any non-digit character are now rejected before that test. The sunos and aix branches of `nvm_get_make_jobs` count cores with `wc -l`, which on those platforms pads the count with whitespace, so that count is now stripped of whitespace before it is checked Discovered by Anthropic's OSS Scanner, as bug ANT-2026-SYLQD6PZ; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	8df635740e	[Fix] nvm_remote_version: match the requested version as a whole version component ... The check that the resolved version actually matches the request used an unanchored substring match on the raw pattern, so `nvm install 20` could accept `v10.20.0` when a remote list's row was selected by a `v20` in its LTS column and no 20.x rows were present. Match the `v`-prefixed pattern followed by a non-digit against the version instead, the same way `nvm_ls_remote_index_tab` normalizes it, so `20` no longer matches `v10.20.0` or `v200.0.0`, while regex-style requests like `4.*` and `v[68]`, and a trailing dot like `8.`, keep working. This also fixes `iojs-1` and `iojs-3`, which previously resolved to N/A because `iojs-3` is not a substring of `iojs-v3.3.1`. Discovered by Anthropic's OSS Scanner, as bug ANT-2026-7GFFYVJP; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	cac4c8d7e0	[Fix] install.sh: a failed script-method download no longer clobbers the install or reports success ... With the script install method, `install_nvm_as_script` downloaded `nvm.sh`, `nvm-exec`, and `bash_completion` directly over the installed files. A dropped connection with curl left a truncated `nvm.sh`, and any wget failure (even just being offline) left all three files empty. Its failure was also ignored by `nvm_do_install`, which went on to edit the profile, source the broken `nvm.sh`, print the success message, and exit 0. Now each file is downloaded to a temporary `.download` name, every download is waited on (by PID, rather than returning while other downloads may still be writing), and the files are moved into place only once all of them have succeeded; on failure, the partial downloads are removed and the existing install is left untouched. `nvm_do_install` now exits with `install_nvm_as_script`'s failure status, matching the git install method Discovered by Anthropic's OSS Scanner, as bug ANT-2026-8TH8YGY5; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	66228bd1fa	[Fix] nvm_ls: match the version pattern literally ... nvm_ls escaped only `.` and `#` before using the pattern (which may come from a `.nvmrc`) as a sed address, so any other regex characters in it were interpreted: `v2[0-9]` matched installed versions, `[` made sed fail with an error, and nested bounded repetitions like `\(v\{1,300\}\)\{1,300\}` made sed take a very long time and a lot of memory to compile, stalling `nvm use` and shell startup. Escape every BRE metacharacter, including the backslash, so the pattern is always matched as literal text Discovered by Anthropic's OSS Scanner, as bug ANT-2026-HZAFTTUK; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	b076039a60	[Tests] nvm install v1 works: get the version from nvm_remote_version, not the ls-remote display ... The test took the last `nvm ls-remote` line and trimmed its whitespace, which kept the markers `ls-remote` adds once that version is installed (a trailing ` *`) or current (a leading `->`), so it passed eg `iojs-v1.8.4 *` to `nvm run` as the version. That only resolved because `nvm_ls` interpreted ` *` as a regex; ask `nvm_remote_version` for the version instead. Discovered by Anthropic's OSS Scanner, as bug ANT-2026-HZAFTTUK; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	6b9650c47f	[Fix] bash_completion: list alias and version names without expanding them ... `__nvm_generate_completion` passed its word list to `compgen -W`, which runs every word through shell expansion. Since that list includes alias file names and installed version directory names, pressing Tab after `nvm use`, `nvm alias`, etc, ran any command substitution in those names, expanded variables in them, and globbed `*` against the current directory. Now the list is split with globbing disabled, and each word is matched against the current word as a literal prefix, so names are offered exactly as written Discovered by Anthropic's OSS Scanner, as bug ANT-2026-QDARMGPO; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan Harband	d8b39c746e	[Fix] nvm_sanitize_auth_header: strip newlines, so wrapped base64 credentials work ... `sed` works one line at a time, so the allowlist never removed newlines inside `NVM_AUTH_HEADER`. A `Basic` credential built with GNU `base64`, which wraps its output at 76 columns, therefore reached the downloader split across several lines, and authentication failed (wget rejects such a header outright). Filter with `tr -cd` instead, using the same set of allowed characters, so CR and LF are deleted like any other disallowed character and a wrapped credential is joined back into one line Discovered by Anthropic's OSS Scanner, as bug ANT-2026-W1E9TAK3; the scanner correctly classified it as not a vulnerability.	2026-10-22 20:10:42 -07:00
Jordan HarbandandElan Ruusamäe	b1b3a0038c	[Fix] nvm_cd: bypass a user-defined cd function ... `\cd` only bypasses aliases, so a user-defined `cd` function (eg, cdhist's) still ran, and broke `NVM_DIR` auto-detection when it rejected zsh's `-q`. Use `command cd`, which skips functions in POSIX shells. zsh's `command` runs `/usr/bin/cd` instead of the builtin, so use `builtin cd` there, as `nvm_echo` does for `printf`. `nvm_die_on_prefix` also now uses `nvm_cd` instead of a bare `cd`. Fixes #3835. See #3836. Co-authored-by: Elan Ruusamäe <glen@delfi.ee>	2026-10-09 21:16:17 -07:00
clifennelandJordan Harband	6dc3765f6b	[readme] Fix a Docker warning from using Docker installation instructions ... Fix a LegacyKeyValueFormat warning when building a Docker image using the 'Installing In Docker' instructions. The warning fixed is: `LegacyKeyValueFormat: "ENV key=value" should be used instead of legacy "ENV key value" format` See: [LegacyKeyValueFormat](https://docs.docker.com/reference/build-checks/legacy-key-value-format/) Co-authored-by: clifennel <li.chr+github@northeastern.edu> Co-authored-by: Jordan Harband <ljharb@gmail.com>	2026-09-15 21:28:51 -07:00
Jordan Harband	5c05fb659c	[actions] cache container images, verified against digests looked up live ... Each container job now looks up the image's index, manifest, and config digests from the registry, keys an `actions/cache` entry on the config digest, and only uses a cached image if its ID matches one of those digests; otherwise it is discarded and the image is pulled (with retries) instead. A poisoned or stale cache entry can therefore never be used, and a cache hit needs only a couple of small manifest requests, so this scales regardless of pull rate limits.	2026-10-09 14:14:20 -07:00
Jordan Harband	37be73f11d	[actions] pull container images through Google's Docker Hub mirror ... DockerHub's anonymous pull rate limit applies per IP for hours, so retrying cannot ride it out on shared runners; `mirror.gcr.io` serves the same official images without that limit, as the io.js source-install job already does.	2026-10-09 14:04:54 -07:00
Saadanjum0	906fb605bc	[Fix] nvm use: handle regex-special characters in $NVM_DIR ... nvm_change_path interpolated `$NVM_DIR` and the new version dir unescaped into grep and sed expressions, so a path containing `&`, `#`, `[`, `*`, etc. corrupted `$PATH` (or made sed fail) when switching versions. Escape them before use.	2026-10-01 16:35:00 +05:00
lazerg	e45c2df7c0	[Fix] install.sh: start a new line before appending to a profile that does not end with one ... Fixes #3951	2026-10-08 18:50:50 +05:00