Commit Graph
100 Commits
Author SHA1 Message Date
Jordan Harband d4cc592ff1 wip 2024-12-16 23:52:31 -08:00
Jordan Harband c8b55175dc [Fix] avoid bash-specific syntax
Fixes #3499
2024-12-19 22:21:09 -08:00
Jordan Harband db0b085965 [Fix] install-latest-npm: npm v11 is out 2024-12-16 10:03:18 -08:00
Jordan Harband 206302caad [Tests] ensure node can be found by npm 2024-11-23 10:12:26 -10:00
Jordan Harband 42a5175402 [Tests] use a newer node version for this test to avoid flakiness 2024-11-22 13:15:01 -10:00
Jordan Harband 02795cd71d [actions] TOC: use latest LTS node 2024-11-22 21:44:36 -10:00
Jordan Harband 0641363102 [Tests] install.sh: clean up nvm_detect_profile tests 2024-11-08 10:52:41 +00:00
Jordan Harband 9659af6c16 [Tests] nvm_detect_profile: refactor 2024-11-12 13:31:36 -08:00
Jordan Harband d648a3b1ba [meta] add DCO
imo this shouldn‘t be necessary, as it should be implied by the act of making a PR.

Following the example in https://github.com/expressjs/express/pull/6048

See https://github.com/openjs-foundation/project-status/issues/2
2024-11-05 17:51:39 +00:00
Jordan Harband ccf6d16017 [meta] disable blank issues 2024-11-04 15:07:16 +00:00
Jordan HarbandandGitHub ba98270442 [meta] update issue template 2024-11-04 15:01:26 +00:00
Jordan Harband 1be4257e96 [Tests] update mocks 2024-10-31 14:23:36 -07:00
Jordan Harband 51ea809d63 [Tests] ensure that unit tests use only mocked LTS names 2024-10-30 23:41:50 -07:00
Jordan Harband 6b70c40f15 [Fix] nvm_install_latest_npm: avoid unbound variable
Fixes #3447
2024-10-22 22:02:01 -07:00
Jordan Harband da2720a429 [Fix] nvm ls, nvm alias, nvm install: error when an LTS name is invalid 2024-09-04 13:55:11 -07:00
Jordan Harband 9fb9dec710 [Fix] nvm_normalize_lts: error when an LTS name is not lowercase
Fixes #3417
2024-09-04 13:54:41 -07:00
Jordan Harband 9a28dbd394 [actions] use node/install instead of node/run 2024-08-28 11:28:52 -07:00
Jordan Harband 179d45050b v0.40.1 2024-08-27 13:44:15 -07:00
Jordan Harband ff7634577b [Tests] fix broken tests exposed by 863bd63
Leaves 2 non-executable, + some TODOs
2024-08-27 12:46:40 -07:00
Jordan Harband 0ce8f5a52f [Fix] nvm_download: ensure all args are quoted
Fixes #3411.
2024-08-20 22:33:38 -07:00
Jordan Harband 863bd63cfa [Tests] set proper permissions on test files 2024-08-23 17:23:12 -07:00
Jordan Harband 0d53381666 [Tests] move sourcing suite to GHA 2024-08-22 13:30:55 -07:00
Jordan Harband df70535248 [Fix] nvm_auto: Fix bug introduced in c31a867 2024-08-21 10:54:19 -07:00
Jordan Harband c31a867c46 [Fix] --save: avoid a conflict with set -e
Fixes #3405.
2024-08-10 15:52:24 +12:00
Jordan Harband a8c418558a [Refactor] --save: clean up some usage 2024-08-20 16:21:45 -07:00
Jordan Harband d5e2c92a25 [Fix] nvm_has_colors: avoid an aliased tput
Fixes #3413
2024-08-20 09:23:45 -07:00
Jordan Harband 81f18bc445 [patch] install.sh: fix node capitalization 2024-08-09 13:46:16 +12:00
Jordan Harband 4beab63631 [Fix] declare an unbound variable
Fixes #3402
2024-08-07 17:38:37 +12:00
Jordan Harband 14acd3dcdd [Fix] nvm install -b: do not attempt to download source on a failed binary download with -b
Fixes #3399
2024-08-01 10:35:37 -07:00
Jordan Harband 271720ebfc [Fix] nvm install -b: when no binary is available, fail and output a clear message 2024-08-01 13:57:22 -07:00
Jordan Harband 423ee82b4c [Tests] fix nvm ls-remote unit test 2024-08-01 10:22:28 -07:00
Jordan Harband deac4e0932 v0.40.0 2024-07-30 12:50:18 -07:00
Jordan Harband b5118ac365 [Dev Deps] update semver 2024-07-30 11:35:15 -07:00
Jordan Harband 24deac7ac5 [readme] add OpenJS Ecosystem Sustainability Program partner
- https://openjsf.org/ecosystem-sustainability-program
2024-07-30 10:08:48 -07:00
Jordan Harband ff1257e8e3 [Refactor] nvm_has_colors: also check the env var 2024-07-28 18:01:14 -07:00
Jordan Harband 87a709741f [Fix] nvm_get_default_packages: use awk for more reliable file processing
See https://github.com/nvm-sh/nvm/commit/db19450caafb37734a3302b24ac9fe2cde40638d

Fixes #3382
2024-07-28 10:02:08 -07:00
Jordan Harband 4c7d899447 [Tests] ignore travis-ci env vars; improve debug output 2024-07-26 12:04:07 -07:00
Jordan Harband 93277112ae [Fix] install-latest-npm: npm ^8.7 breaks npm ls with file: deps 2024-07-26 09:16:03 -07:00
Jordan Harband 762f9ef9d1 [Tests] only install python 2.7 if not already installed
See ee6f7667 / #3067
2024-07-06 10:29:55 -05:00
Jordan Harband e597bb208e [Tests] use a better JSON parsing implementation 2024-06-10 11:33:12 -07:00
Jordan Harband aa427ad396 [Tests] ensure travis can access public repo submodules 2024-06-10 09:15:16 -07:00
Jordan Harband c20db2ab86 [actions] improve default action permissions 2024-06-10 08:59:48 -07:00
Jordan HarbandandYash Singh 29dce5edfd [New] allow .nvmrc files to support comments
In theory, `npx nvmrc` can now be used to validate an `.nvmrc` file that `nvm` will support. Allowances have been made for future extensibility, and aliases may no longer contain a `#`.

Fixes #3336. Closes #2288.

Co-authored-by: Jordan Harband <ljharb@gmail.com>
Co-authored-by: Yash Singh <saiansh2525@gmail.com>
2024-06-07 10:13:00 -07:00
Jordan Harband 95081f0bc2 [readme] update CII badge URLs 2024-06-06 14:19:11 -07:00
Jordan Harband 1750b8d327 [actions] update vampire/setup-wsl action 2024-05-30 12:37:36 -07:00
Jordan Harband 97093dc1b3 [Dev Deps] update markdown-link-check, semver 2024-05-30 12:36:26 -07:00
Jordan Harband 811c039e2b [actions] finisher tweaks 2024-03-08 22:28:53 -08:00
Jordan HarbandandGitHub 6c9cd2f2d1 [security] fix typo in threat model 2023-12-15 09:46:35 -08:00
Jordan Harband bab86d5de5 v0.39.7 2023-12-05 21:50:27 -08:00
Jordan Harband d86f270438 [Fix] use \hash instead of command hash for zsh
See #3239; Fixes #3247; Closes #3246
2023-12-05 21:48:51 -08:00
Jordan Harband c73009f503 v0.39.6 2023-12-04 22:03:25 -08:00
Jordan Harband b1fa143dd8 [Fix] nvm_get_mirror: ensure only a valid URL is allowed 2023-12-02 14:44:46 -08:00
Jordan Harband cc765cc000 [Fix] avoid overridden hash
Fixes #3239
2023-11-24 20:42:53 -08:00
Jordan Harband 99646ee600 [security] add threat model 2023-11-15 10:10:29 -08:00
Jordan Harband b356fab4b4 [meta] fix gitattributes to properly recognize images as binary 2023-11-22 22:29:01 -08:00
Jordan Harband 6b15796f66 [Tests] temporarily allow cygwin tests to fail 2023-12-04 15:49:09 -08:00
Jordan Harband 3e51872b98 [Tests] temporarily allow WSL tests to fail
See https://github.com/Vampire/setup-wsl/issues/50 / https://github.com/actions/runner-images/discussions/8791
2023-12-04 13:06:24 -08:00
Jordan Harband 4bdd57ba0f [Fix] install.sh: when NVM_INSTALL_GITHUB_REPO is set, issue a warning
This should only annoy those testing their PRs; real users should never set this env var
2023-11-02 21:10:09 -07:00
Jordan Harband d02ddcac2c [Fix] nvm_get_mirror: disallow some non-URL characters
This should be improved in the future, but is fine for now
2023-11-01 21:01:28 -07:00
Jordan Harband b64e5474ea [Tests] ensure windows tests install a node that actually works
- disable failing Alpine tests
 - disable Ubuntu-18.04 tests on node 18+
 - add Ubuntu-20.04 tests
2023-11-01 16:12:12 -07:00
Jordan Harband 1f970ccb7a [Fix] nvm_normalize_lts: switch from expr to case
avoids `expr: warning: ^lts/-[1-9][0-9]*: using ^ as the first character of a basic regular expression is not portable; it is ignored`
2023-11-01 12:24:29 -07:00
Jordan Harband 6743aef70c [New] nvm_resolve_alias: only resolve one line of a multiline alias file 2023-10-23 14:41:14 -07:00
Jordan Harband 10cdda081f [Tests] update test mocks (new LTS, iron) 2023-10-25 15:39:12 -07:00
Jordan Harband 8241287349 [New] aliases: skip leading blank lines in alias file 2023-10-23 14:06:19 -07:00
Jordan Harband 6aeab3349c [Robustness] nvm_list_aliases: avoid overwritten sort 2023-10-23 14:05:37 -07:00
Jordan Harband bfce5889f7 [Test] update test mocks 2023-10-23 14:53:39 -07:00
Jordan Harband 2426a0c4b2 [security] add prose explaining OpenSSF CII Best Practices badge results
Fixes https://github.com/openjs-foundation/security-collab-space/issues/35.
2023-10-20 15:58:27 -07:00
Jordan Harband 414e8d426f [Tests] switch cygwin mirror 2023-10-09 14:50:40 -07:00
Jordan Harband 1eaaada499 [Perf] nvm_check_file_permissions: do not traverse into symlinks 2023-08-25 22:49:41 -07:00
Jordan Harband c92adb3c47 v0.39.5 2023-08-21 21:10:10 -07:00
Jordan Harband 324b81a722 [Fix] allow checksums to pass with a leading backslash
See https://unix.stackexchange.com/a/555061/137489
2023-08-06 14:51:48 +12:00
Jordan Harband 55075db96d [Tests] add some nvm_do_install tests 2022-12-27 22:57:07 -08:00
Jordan Harband 4618ce0aa1 [Tests] a cleaner name for the windows tests 2022-12-27 22:32:09 -08:00
Jordan Harband 3afdce0a2c [Fix] nvm install-latest-npm: ensure npm 10 does not install on unsupported nodes
See https://github.com/npm/cli/pull/6674
2023-07-26 13:21:03 -07:00
Jordan Harband 8fbf8ab694 v0.39.4 2023-07-24 18:29:54 -07:00
Jordan Harband 4fc91d408c [Dev Deps] update markdown-link-check, semver 2023-07-24 18:24:39 -07:00
Jordan Harband c08b38a2a4 [Fix] nvm_print_npm_version: if npm exists but its node crashes, do not print the npm version 2023-04-28 10:57:57 -07:00
Jordan Harband a07cd41af1 [Fix] nvm_ls_current: when node is present but crashes immediately, echo "none" 2023-04-28 10:55:03 -07:00
Jordan Harband b1331c20b0 [Tests] add unit tests for nvm_download_artifact 2023-04-06 09:23:33 -07:00
Jordan Harband 946da2e743 [Dev Deps] update markdown-link-check 2023-03-22 16:20:48 -07:00
Jordan Harband ea3b65f02e [Tests] npm bin has been removed 2023-03-21 13:31:52 -07:00
Jordan Harband f36516b472 [Tests] move install script tests to github actions 2022-10-26 14:47:18 -07:00
Jordan Harband dc691121b8 [Tests] improve debug output on failure 2022-12-27 21:41:39 -08:00
Jordan Harband ce35311657 [Tests] force the NVM_DIR to the expected location, for tests 2022-12-27 21:40:48 -08:00
Jordan Harband a60ac08a80 [actions] allow nvm to be installed 2022-12-26 13:22:07 -08:00
Jordan Harband 552db40622 v0.39.3 2022-12-23 12:57:56 -08:00
Jordan Harband 788c0a425e [meta] use HEAD instead of master where possible 2022-12-23 12:53:40 -08:00
Jordan Harband d0bc227127 [Tests] update test mocks 2022-12-22 16:07:00 -08:00
Jordan Harband bf438742a7 [Tests] move installation_node tests back to xenial 2022-12-22 16:16:10 -08:00
Jordan Harband 447940acb3 [Tests] move tests that fail on focal to a separate suite that runs on xenial 2022-12-22 11:26:27 -08:00
Jordan Harband 0ec2ca979c [Tests] update travis to use focal
- xenial can't build node 18
 - bionic can't build node 0.6 or 18
2022-10-26 11:12:19 -07:00
Jordan Harband b86c91efe3 [actions] fix latest-npm tests so they use this repo’s nvm instead of the last published one 2022-12-22 15:27:46 -08:00
Jordan Harband ac357c59ef [Fix] nvm install-latest-npm: npm v6.14.18 can not be installed from npm < v4.4.4 2022-12-21 14:28:15 -08:00
Jordan Harband abe5e30a9d [shellcheck] remove duplicate function 2022-12-22 13:00:12 -08:00
Jordan Harband 4c4b0d64ed [Tests] fix nvm_list_aliases test to use mocks for LTS aliases 2022-10-26 10:31:26 -07:00
Jordan Harband e6fa80cb61 [Dev Deps] update doctoc, markdown-link-check, replace, semver 2022-10-26 10:13:39 -07:00
Jordan Harband 1f4bb91ae6 [Fix] ensure this variable is bound
Fixes #2926
2022-10-26 10:12:06 -07:00
Jordan Harband 924d77cc90 [Fix] debug: correct mistaken -V to --version from #2922 2022-10-24 10:51:20 -07:00
Jordan Harband df84c77a81 [actions] update some actions deps 2022-10-16 17:51:14 -07:00
Jordan Harband df01d81128 [Refactor] add nvm_wrap_with_color_code; allow no color code 2022-10-13 20:16:42 -07:00