[Fix] nvm_ls_cached: only match whole version numbers
An unanchored `grep` let a pattern match any cached version containing it, so `nvm install --offline 20.1.1` could install a cached v20.1.10, and `nvm install --offline iojs`, whose pattern is empty, matched every cached node version.
This commit is contained in:
2 files changed
+5
-1
No files matched your search
@@ -4027,7 +4027,7 @@ nvm_ls_cached() {
|
|||||||
fi
|
fi
|
||||||
} \
|
} \
|
||||||
| command sed 's/^node-//' \
|
| command sed 's/^node-//' \
|
||||||
| nvm_grep "$(nvm_ensure_version_prefix "${PATTERN}")" \
|
| nvm_grep -w "$(nvm_ensure_version_prefix "${PATTERN:-.*}")" \
|
||||||
| command sort -t. -u -k 1.2,1n -k 2,2n -k 3,3n
|
| command sort -t. -u -k 1.2,1n -k 2,2n -k 3,3n
|
||||||
}
|
}
|
||||||
|
|
||||||
|
|||||||
@@ -50,6 +50,10 @@ try nvm_ls_cached "v0.99.98"
|
|||||||
[ "_$CAPTURED_STDOUT" = "_v0.99.98" ] \
|
[ "_$CAPTURED_STDOUT" = "_v0.99.98" ] \
|
||||||
|| die "nvm_ls_cached 'v0.99.98' should find the bin-cached node version; got '$CAPTURED_STDOUT'"
|
|| die "nvm_ls_cached 'v0.99.98' should find the bin-cached node version; got '$CAPTURED_STDOUT'"
|
||||||
|
|
||||||
|
try nvm_ls_cached "v0.99.9"
|
||||||
|
[ -z "$CAPTURED_STDOUT" ] \
|
||||||
|
|| die "nvm_ls_cached 'v0.99.9' should not match a longer version number; got '$CAPTURED_STDOUT'"
|
||||||
|
|
||||||
try nvm_ls_cached "iojs-v0.99.97"
|
try nvm_ls_cached "iojs-v0.99.97"
|
||||||
[ "_$CAPTURED_STDOUT" = "_iojs-v0.99.97" ] \
|
[ "_$CAPTURED_STDOUT" = "_iojs-v0.99.97" ] \
|
||||||
|| die "nvm_ls_cached 'iojs-v0.99.97' should find the bin-cached io.js version; got '$CAPTURED_STDOUT'"
|
|| die "nvm_ls_cached 'iojs-v0.99.97' should find the bin-cached io.js version; got '$CAPTURED_STDOUT'"
|
||||||
|
|||||||
Reference in new issue
Block a user