Commit Graph

538 Commits

Author SHA1 Message Date
Yeachan-Heo
c3b0e12164 Remove unshipped rusty-claude-cli prototype modules
The shipped CLI surface lives in `src/main.rs`, which only wires `init`,
`input`, and `render`. The legacy `app.rs` and `args.rs` prototypes were
not in the module tree and had no inbound references, so this change deletes
those orphaned files instead of widening scope into a larger refactor.

It also aligns the TUI enhancement plan with that reality so the document no
longer describes the removed prototypes as current tracked structure.

Constraint: Must preserve shipped CLI parsing and slash-command behavior
Rejected: Refactor main.rs into smaller modules now | widens scope beyond behavior-safe cleanup
Rejected: Leave TUI plan wording untouched | leaves low-risk stale documentation behind
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep this slice deletion-first; do not reintroduce alternate CLI surfaces without wiring them into main.rs and its tests
Tested: cargo test -p rusty-claude-cli defaults_to_repl_when_no_args
Tested: cargo test -p rusty-claude-cli parses_login_and_logout_subcommands
Tested: cargo test -p rusty-claude-cli parses_direct_agents_mcp_and_skills_slash_commands
Tested: cargo test -p rusty-claude-cli direct_slash_commands_surface_shared_validation_errors
Tested: cargo test -p rusty-claude-cli parses_resume_flag_with_multiple_slash_commands -- --nocapture
Tested: cargo test -p rusty-claude-cli resumed_binary_accepts_slash_commands_with_arguments -- --nocapture
Tested: cargo check -p rusty-claude-cli
Tested: git diff --check
Not-tested: cargo clippy -p rusty-claude-cli --all-targets -- -D warnings (pre-existing failures in rust/crates/runtime/* and existing warnings outside this diff)
2026-04-05 17:44:34 +00:00
Yeachan-Heo
31163be347 style: cargo fmt 2026-04-05 16:56:48 +00:00
Yeachan-Heo
eb4d3b11ee merge fix/p2-19-subcommand-help-fallthrough 2026-04-05 16:54:59 +00:00
Yeachan-Heo
9bd7a78ca8 Merge branch 'fix/p2-18-context-window-preflight' 2026-04-05 16:54:45 +00:00
Yeachan-Heo
24d8f916c8 merge fix/p0-10-json-status 2026-04-05 16:54:38 +00:00
Yeachan-Heo
30883bddbd Keep doctor and local help paths shell-native
Promote doctor into a real top-level CLI action, reuse the same local report for resumed and REPL doctor invocations, and intercept doctor/status/sandbox help flags before prompt-mode dispatch. The parser change also closes the help fallthrough that previously wandered into runtime startup for local-info commands.

Constraint: Preserve prompt shorthand for normal multi-word text input while fixing exact local subcommand help paths
Rejected: Route \7⠋ 🦀 Thinking...8✘  Request failed
 through prompt/slash guidance | still shells out through the wrong surface and keeps health checks hidden
Rejected: Reuse the status report as doctor output | status does not explain auth/config health or expose a dedicated diagnostic summary
Confidence: high
Scope-risk: narrow
Directive: Keep doctor local-only unless an explicit network probe is intentionally added and separately tested
Tested: cargo build -p rusty-claude-cli; cargo test -p rusty-claude-cli; cargo run -p rusty-claude-cli -- doctor --help; CLAW_CONFIG_HOME=/tmp/tmp.7pm9SVzOPN ANTHROPIC_API_KEY= ANTHROPIC_AUTH_TOKEN= cargo run -p rusty-claude-cli -- doctor
Not-tested: direct /doctor outside the REPL remains interactive-only
2026-04-05 16:44:36 +00:00
Yeachan-Heo
1a2fa1581e Keep status JSON machine-readable for automation
The global --output-format json flag already reached prompt-mode responses, but
status and sandbox still bypassed that path and printed human-readable tables.
This change threads the selected output format through direct command aliases
and resumed slash-command execution so status queries emit valid structured
JSON instead of mixed prose.

It also adds end-to-end regression coverage for direct status/sandbox JSON
and resumed /status JSON so shell automation can rely on stable parsing.

Constraint: Global output formatting must stay compatible with existing text-mode reports
Rejected: Require callers to scrape text status tables | fragile and breaks automation
Confidence: high
Scope-risk: narrow
Directive: New direct commands that honor --output-format should thread the format through CliAction and resumed slash execution paths
Tested: cargo build -p rusty-claude-cli
Tested: cargo test -p rusty-claude-cli -- --nocapture
Tested: cargo test --workspace
Tested: cargo run -q -p rusty-claude-cli -- --output-format json status
Tested: cargo run -q -p rusty-claude-cli -- --output-format json sandbox
Not-tested: cargo clippy --workspace --all-targets -- -D warnings (fails in pre-existing runtime files unrelated to this change)
2026-04-05 16:41:02 +00:00
Yeachan-Heo
fa72cd665e Block oversized requests before providers hard-fail
The runtime already tracked rough token estimates for compaction, but provider-bound
requests still relied on naive model output limits and could be sent upstream even
when the selected model could not fit the estimated prompt plus requested output.

This adds a small model token/context registry in the API layer, estimates request
size from the serialized prompt payload, and fails locally with a dedicated
context-window error before Anthropic or xAI calls are made. Focused integration
coverage asserts the preflight fires before any HTTP request leaves the process.

Constraint: Keep the first pass minimal and reusable across both Anthropic and OpenAI-compatible providers
Rejected: Auto-compact-and-retry in the same patch | broader control-flow change than the requested minimal preflight
Confidence: medium
Scope-risk: narrow
Reversibility: clean
Directive: Expand the model registry before enabling preflight for additional providers or aliases
Tested: cargo build -p api -p tools -p rusty-claude-cli; cargo test -p api
Not-tested: End-to-end CLI auto-compaction or retry behavior after a local context_window_blocked failure
2026-04-05 16:39:58 +00:00
Yeachan-Heo
1f53d961ff Route nested CLI help requests to usage instead of operand fallthrough
The direct CLI wrappers for agents, skills, and mcp treated nested help flags as ordinary operands. That made commands like `claw mcp show --help` report a missing server and `claw skills install --help` fall into filesystem install logic instead of surfacing usage.

This change normalizes help-path arguments before dispatch so nested help stays on the help path. The regression tests cover both handler-level behavior and end-to-end CLI output for nested help and unknown subcommands with trailing help flags.

Constraint: Keep the fix scoped to direct CLI slash-command wrappers without changing unrelated parser behavior
Rejected: Rework top-level argument parsing for all subcommands | broader risk than needed for the regression
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: If more nested subcommands are added, extend the help-path normalization table before relying on raw operand dispatch
Tested: cargo build -p commands -p rusty-claude-cli
Tested: cargo test -p commands -p rusty-claude-cli
Not-tested: cargo clippy -p commands -p rusty-claude-cli --all-targets --no-deps -- -D warnings (pre-existing warnings in untouched files block clean run)
2026-04-05 16:38:43 +00:00
Yeachan-Heo
b9c5cc118e docs: add subcommand help fallthrough pinpoint 2026-04-05 14:46:02 +00:00
Yeachan-Heo
38fa2778af docs: add context-window preflight gap pinpoint 2026-04-05 14:46:02 +00:00
Yeachan-Heo
c4d4daa41d docs: add P2.16 orphaned module integration audit pinpoint
session_control is pub exported but has zero consumers workspace-wide.
trust_resolver types are re-exported but never instantiated outside
unit tests. These implement core clawability contracts that are
structurally dead — built but not wired into the actual execution path.
2026-04-05 14:46:02 +00:00
Yeachan-Heo
3df5dece39 fix: suppress dead_code warnings for unused file_ops functions 2026-04-05 03:23:51 +00:00
Yeachan-Heo
cd1ee43f33 fix: suppress dead_code warnings for unused provider and lane completion items 2026-04-05 03:22:32 +00:00
Yeachan-Heo
1fb3759e7c fix: remove unused imports in session_control.rs 2026-04-05 03:21:55 +00:00
Yeachan-Heo
6b73f7f410 docs: add roadmap item for output format contract audit 2026-04-04 23:00:49 +00:00
Yeachan-Heo
f30251a9e1 docs: add roadmap item for json inventory command output 2026-04-04 22:30:46 +00:00
Yeachan-Heo
b0b655d417 docs: add roadmap item for config namespace unification 2026-04-04 22:01:03 +00:00
Yeachan-Heo
8e72aaee2e docs: add roadmap item for json status output parity 2026-04-04 21:30:47 +00:00
Yeachan-Heo
1ceb077e40 docs: add roadmap item for top-level doctor command 2026-04-04 21:00:54 +00:00
Yeachan-Heo
58903cef75 docs: add roadmap item for warning-free first-run UX 2026-04-04 20:30:46 +00:00
Yeachan-Heo
cad1ac32a0 docs: add roadmap item for README reality reconciliation 2026-04-04 20:00:36 +00:00
Yeachan-Heo
1f52ce25fb docs: fix stale star history branding and add docs residue check 2026-04-04 19:30:54 +00:00
Yeachan-Heo
9350e70bc5 docs: add roadmap item for doctor discoverability 2026-04-04 19:00:45 +00:00
Yeachan-Heo
25a19792aa docs: add roadmap item for container-first docs 2026-04-04 18:30:34 +00:00
Yeachan-Heo
89a869e261 docs: add roadmap item for release-grade binary workflow 2026-04-04 18:00:37 +00:00
Yeachan-Heo
460284e7df docs: add roadmap item for workspace-grade ci coverage 2026-04-04 17:30:35 +00:00
Yeachan-Heo
feddbdd598 docs: add roadmap item for commit provenance push events 2026-04-04 17:00:46 +00:00
Yeachan-Heo
c99ee2f65d docs: switch community section to ultraworkers discord 2026-04-04 16:56:31 +00:00
Yeachan-Heo
78fd0216f4 docs: add philosophy document for autonomous claw development 2026-04-04 16:51:51 +00:00
Yeachan-Heo
aca03fc3f9 docs: rewrite README around autonomous claw maintenance 2026-04-04 16:50:05 +00:00
Yeachan-Heo
9a7aab5259 docs: replace instructkr sponsor callout with ultraworkers shout-out 2026-04-04 16:49:02 +00:00
Yeachan-Heo
22ad54c08e docs: describe the runtime public API surface
This adds crate-level and type-level Rustdoc to the runtime crate's core exported types so downstream crates and contributors can understand the session, prompt, permission, OAuth, usage, and tool I/O primitives without spelunking every implementation file.

Constraint: The docs pass needed to stay focused on public runtime types without changing behavior
Rejected: Add blanket docs to every public item in one sweep | larger churn than needed for a targeted docs pass
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: When exporting new runtime primitives from lib.rs, add a short Rustdoc summary in the defining module at the same time
Tested: cargo build --workspace; cargo test --workspace
Not-tested: rustdoc HTML rendering beyond  doc-test coverage
2026-04-04 15:23:29 +00:00
Yeachan-Heo
953513f12d docs: add a current claw CLI usage guide
The root and Rust-facing docs now point readers at a single task-oriented usage guide with build, auth, CLI, session, and parity-harness examples. This also fixes stale workspace references and updates the Rust workspace inventory to match the current crate set.

Constraint: Existing README copy still referenced the old dev/rust status and needed to stay lightweight
Rejected: Fold all usage details into README.md only | too much noise for the landing page
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep USAGE examples aligned with  when CLI flags change
Tested: cargo build --workspace; cargo test --workspace
Not-tested: External links and rendered Markdown in GitHub UI
2026-04-04 15:23:22 +00:00
Jobdori
fbb2275ab4 docs: mark P2.14 complete in ROADMAP
Config merge validation gap fixed at 5bee22b:
- Hook validation before deep-merge in config.rs
- Source-path context for malformed entries
- Prevents non-string hook arrays from poisoning runtime
2026-04-05 00:16:07 +09:00
Yeachan-Heo
5bee22b66d Prevent invalid hook configs from poisoning merged runtime settings
Validate hook arrays in each config file before deep-merging so malformed entries fail with source-path context instead of surfacing later as a merged hook parse error.

Constraint: Runtime hook config currently supports only string command arrays
Rejected: Add hook-specific schema logic inside deep_merge_objects | keeps generic merge helper decoupled from config semantics
Confidence: high
Scope-risk: narrow
Reversibility: clean
Directive: Keep hook validation source-aware before generic config merges so file-specific errors remain diagnosable
Tested: cargo build --workspace; cargo test --workspace
Not-tested: live claw --help against a malformed external user config
2026-04-04 15:15:29 +00:00
Jobdori
5b9e47e294 docs: mark P2.11 complete in ROADMAP
Structured task packet format shipped at dbfc9d5:
- TaskPacket struct with validation and serialization
- TaskScope resolution (workspace/module/single-file/custom)
- Integration into tools/src/lib.rs
- task_registry.rs coordination for runtime task tracking
2026-04-05 00:11:58 +09:00
Yeachan-Heo
dbfc9d521c Track runtime tasks with structured task packets
Replace the oversized packet model with the requested JSON-friendly packet shape and thread it through the in-memory task registry. Add the RunTaskPacket tool so callers can launch packet-backed tasks directly while preserving existing task creation flows.

Constraint: The existing task system and tool surface had to keep TaskCreate behavior intact while adding packet-backed execution

Rejected: Add a second parallel packet registry | would duplicate task lifecycle state

Confidence: high

Scope-risk: moderate

Reversibility: clean

Directive: Keep TaskPacket aligned with the tool schema and task registry serialization when extending the packet contract

Tested: cargo build --workspace; cargo test --workspace

Not-tested: live end-to-end invocation of RunTaskPacket through an interactive CLI session
2026-04-04 15:11:26 +00:00
Jobdori
340d4e2b9f docs: mark P2 backlog items complete in ROADMAP
Updated ROADMAP to reflect shipped P2 items:
- P2.7: Canonical lane event schema in clawhip
- P2.8: Failure taxonomy + blocker normalization
- P2.9: Stale-branch detection before workspace tests
- P2.10: MCP structured degraded-startup reporting
- P2.12: Lane board / machine-readable status API

Remaining P2: P2.11 (task packets - in progress), P2.14 (config merge), P2.15 (flaky test)
2026-04-04 23:52:11 +09:00
Jobdori
db1daadf3e docs: mark P2.5 and P2.6 complete in ROADMAP
Worker boot recovery hardening landed:
- P2.5: Worker readiness handshake + trust resolution (state machine)
- P2.6: Prompt misdelivery detection and recovery (replay arm)

[source: direct_development]
2026-04-04 23:51:52 +09:00
Yeachan-Heo
784f07abfa Harden worker boot recovery before task dispatch
The worker boot registry now exposes the requested lifecycle states, emits structured trust and prompt-delivery events, and recovers from shell or wrong-target prompt delivery by replaying the last prompt. Supporting fixes keep MCP remote config parsing backwards-compatible and make CLI argument parsing less dependent on ambient config and cwd state so the workspace stays green under full parallel test runs.

Constraint: Worker prompts must not be dispatched before a confirmed ready_for_prompt handshake
Constraint: Prompt misdelivery recovery must stay minimal and avoid new dependencies
Rejected: Keep prompt_accepted and blocked as public lifecycle states | user requested the narrower explicit state set
Rejected: Treat url-only MCP server configs as invalid | existing CLI/runtime tests still rely on that shorthand
Confidence: high
Scope-risk: moderate
Reversibility: clean
Directive: Preserve prompt_in_flight semantics when extending worker boot; misdelivery detection depends on it
Tested: cargo build --workspace; cargo test --workspace
Not-tested: Live tmux worker delivery against a real external coding agent pane
2026-04-04 14:50:43 +00:00
Jobdori
d87fbe6c65 chore(ci): ignore flaky mcp_stdio discovery test
Temporarily ignore manager_discovery_report_keeps_healthy_servers_when_one_server_fails
to unblock worker-boot session progress. Test has intermittent timing issues in CI
that need proper investigation and fix.

- Add #[ignore] attribute with reference to ROADMAP P2.15
- Add P2.15 backlog item for root cause fix

Related: clawcode-p2-worker-boot session was blocked on this test failing twice.
2026-04-04 23:41:56 +09:00
Yeachan-Heo
8a9ea1679f feat(mcp+lifecycle): MCP degraded-startup reporting, lane event schema, lane completion hardening
Add MCP structured degraded-startup classification (P2.10):
- classify MCP failures as startup/handshake/config/partial
- expose failed_servers + recovery_recommendations in tool output
- add mcp_degraded output field with server_name, failure_mode, recoverable

Canonical lane event schema (P2.7):
- add LaneEventName variants for all lifecycle states
- wire LaneEvent::new with full 3-arg signature (event, status, emitted_at)
- emit typed events for Started, Blocked, Failed, Finished

Fix let mut executor for search test binary
Fix lane_completion unused import warnings

Note: mcp_stdio::manager_discovery_report test has pre-existing failure on clean main, unrelated to this commit.
2026-04-04 14:31:56 +00:00
Yeachan-Heo
639a54275d Stop stale branches from polluting workspace test signals
Workspace-wide verification now preflights the current branch against main so stale or diverged branches surface missing commits before broad cargo tests run. The lane failure taxonomy is also collapsed to the blocker classes the roadmap lane needs so automation can branch on a smaller, stable set of categories.

Constraint: Broad workspace tests should not run when main is ahead and would produce stale-branch noise
Rejected: Run workspace tests unconditionally | makes stale-branch failures indistinguishable from real regressions
Confidence: medium
Scope-risk: moderate
Reversibility: clean
Directive: Keep workspace-test preflight scoped to broad test commands until command classification grows more precise
Tested: cargo test -p runtime stale_branch -- --nocapture; cargo test -p tools lane_failure_taxonomy_normalizes_common_blockers -- --nocapture; cargo test -p tools bash_workspace_tests_are_blocked_when_branch_is_behind_main -- --nocapture; cargo test -p tools bash_targeted_tests_skip_branch_preflight -- --nocapture
Not-tested: clean worktree cargo test --workspace still fails on pre-existing rusty-claude-cli tests default_permission_mode_uses_project_config_when_env_is_unset and single_word_slash_command_names_return_guidance_instead_of_hitting_prompt_mode
2026-04-04 14:01:31 +00:00
Jobdori
fc675445e6 feat(tools): add lane_completion module (P1.3)
Implement automatic lane completion detection:
- detect_lane_completion(): checks session-finished + tests-green + pushed
- evaluate_completed_lane(): triggers CloseoutLane + CleanupSession actions
- 6 tests covering all conditions

Bridges the gap where LaneContext::completed was a passive bool
that nothing automatically set. Now completion is auto-detected.

ROADMAP P1.3 marked done.
2026-04-04 22:05:49 +09:00
Jobdori
ab778e7e3a docs(ROADMAP): mark P1.2 and P1.4 as done
- P1.2: Cross-module integration tests — 12 tests landed
- P1.4: SummaryCompressor wiring — compress_summary_text() feeds
  into LaneEvent::Finished detail field

Both verified in codebase. P1.3 (lane-completion emitter) remains open.
2026-04-04 21:38:05 +09:00
Jobdori
11c418c6fa docs(ROADMAP): update P2 backlog with completion status and new gap
- P2.13: Mark session completion failure classification as done
  (WorkerFailureKind::Provider + observe_completion() + recovery bridge)
- P2.14: Add config merge validation gap (active bug being fixed in
  clawcode-issue-9507-claw-help-hooks-merge lane)

The config merge bug: deep_merge_objects() can produce non-string
values in hooks arrays, which fail validation in optional_string_array()
at claw --help time with 'field PreToolUse must contain only strings'.
2026-04-04 21:33:01 +09:00
Jobdori
8b2f959a98 test(runtime): add worker→recovery→policy integration test
Adds worker_provider_failure_flows_through_recovery_to_policy():
- Worker boots, sends prompt, encounters provider failure
- observe_completion() classifies as WorkerFailureKind::Provider
- from_worker_failure_kind() bridges to FailureScenario
- attempt_recovery() executes RestartWorker recipe
- Post-recovery context evaluates to merge-ready via PolicyEngine

Completes the P2.8/P2.13 wiring verification with a full cross-module
integration test. 660 tests pass.
2026-04-04 21:27:44 +09:00
Jobdori
9de97c95cc feat(recovery): bridge WorkerFailureKind to FailureScenario (P2.8/P2.13)
Connect worker_boot failure classification to recovery_recipes policy:

- Add FailureScenario::ProviderFailure variant
- Add FailureScenario::from_worker_failure_kind() bridge function
  mapping every WorkerFailureKind to a concrete FailureScenario
- Add RecoveryStep::RestartWorker for provider failure recovery
- Add recipe for ProviderFailure: RestartWorker -> AlertHuman escalation
- 3 new tests: bridge mapping, recipe structure, recovery attempt cycle

Previously a claw that detected WorkerFailureKind::Provider had no
machine-readable path to 'what should I do about this?'. Now it can
call from_worker_failure_kind() -> recipe_for() -> attempt_recovery()
as a single structured chain.

Closes the silo between worker_boot and recovery_recipes.
2026-04-04 20:07:36 +09:00
Jobdori
736069f1ab feat(worker_boot): classify session completion failures (P2.13)
Add WorkerFailureKind::Provider variant and observe_completion() method
to classify degraded session completions as structured failures.

- Detects finish='unknown' + zero tokens as provider failure
- Detects finish='error' as provider failure
- Normal completions transition to Finished state
- 2 new tests verify classification behavior

This closes the gap where sessions complete but produce no output,
and the failure mode wasn't machine-readable for recovery policy.

ROADMAP P2.13 backlog item added.
2026-04-04 19:37:57 +09:00