mirror of
https://github.com/nvm-sh/nvm.git
synced 2026-07-18 12:58:21 +08:00
Jordan Harband
04fef13bdc
zsh (and interactive bash with `expand_aliases`) bakes a preexisting `curl` alias into nvm's function bodies at source time, and shell functions named `curl`/`wget` shadow the binaries at call time - either one breaks downloads. Prefixing invocations with `command` bypasses both: here, `nvm_download`'s dispatch, `nvm_curl_version`, `nvm_curl_libz_support`, and the wget branch of `nvm_get_latest`; the remaining bare `curl` invocations in `nvm_get_latest` and the install script are prefixed in a followup commit. The tests that previously mocked curl/wget as shell functions now install fake executables on PATH instead, via a shared `make_fake_curl` helper in `test/common.sh`, and a new test asserts the bypass. Refs #2923
39 lines
1001 B
Bash
Executable File
39 lines
1001 B
Bash
Executable File
#!/bin/sh
|
|
|
|
WORK="$PWD/nvm_curl_version-work.$$"
|
|
TEST_BIN="$WORK/bin"
|
|
|
|
cleanup () {
|
|
unset -f die cleanup assert_version_is
|
|
rm -rf "$WORK"
|
|
export PATH="$OLDPATH"
|
|
}
|
|
|
|
die () { echo -e "$@" ; cleanup ; exit 1; }
|
|
|
|
NVM_ENV=testing \. ../../../nvm.sh
|
|
|
|
\. ../../common.sh
|
|
|
|
OLDPATH="$PATH"
|
|
|
|
make_fake_curl "$TEST_BIN"
|
|
|
|
export PATH="$TEST_BIN:$OLDPATH"
|
|
|
|
assert_version_is() {
|
|
if [ "${1}" != "${2}" ]; then
|
|
die "Expected ${2}, got ${1}, origin version message:\n${VERSION_MESSAGE}"
|
|
return 1
|
|
fi
|
|
}
|
|
|
|
CURL_VERSION_MESSAGE="curl 7.54.0 (x86_64-pc-linux-gnu) libcurl/7.54.0 OpenSSL/1.1.0f zlib/1.2.11 libpsl/0.17.0 (+libicu/59.1) libssh2/1.8.0 nghttp2/1.22.0
|
|
Protocols: dict file ftp ftps gopher http https imap imaps pop3 pop3s rtsp scp sftp smb smbs smtp smtps telnet tftp
|
|
Features: AsynchDNS IPv6 Largefile GSS-API Kerberos SPNEGO NTLM NTLM_WB SSL libz TLS-SRP HTTP2 UnixSockets HTTPS-proxy PSL"
|
|
|
|
VERSION_MESSAGE="${CURL_VERSION_MESSAGE}"
|
|
assert_version_is "$(nvm_curl_version)" "7.54.0"
|
|
|
|
cleanup
|