1125 Commits

Include renames

Author	SHA1	Message	Date
Jordan Harband	b6cf55f6ad	v0.40.6	2026-07-15 14:09:54 -07:00
Jordan Harband	9275c5badd	[Robustness] reject unsafe LTS alias names from a mirror's index.tab ... A mirror-supplied LTS codename (field 10 of index.tab) was used verbatim as an alias filename, so a hostile codename such as `../../../.bashrc` could make nvm_make_alias write outside $NVM_DIR/alias - with the default layout, into shell startup files. Constrain remote codenames to safe filename characters at ingestion in nvm_ls_remote_index_tab, and reject any `..` path component in nvm_make_alias as a backstop for every caller.	2026-07-15 13:46:52 -07:00
Jordan Harband	f1e7a84cb5	[Robustness] avoid a set -u error when $_ is unset ... Sourcing nvm.sh under `set -u` on a POSIX shell that leaves `$_` unset (e.g. busybox ash or dash on Alpine, where the parent shell does not export it) aborted at `NVM_SCRIPT_SOURCE="$_"`. Default to empty; the only consumer already falls back to `$0`.	2026-07-14 23:16:39 -07:00
Jordan Harband	86c937436d	[Robustness] nvm_get_arch: only apply the Alpine musl suffix when the OS is linux ... The `/etc/alpine-release` check applied the -musl suffix regardless of the resolved OS. In practice Alpine is always linux, so this is behavior-neutral, but it also makes the `nvm_get_arch` unit test hermetic: its mocked smartos/osx cases no longer pick up a real host's Alpine marker.	2026-07-14 23:10:33 -07:00
Jesse ZhuandJordan Harband	ce157c1171	[Fix] support arm64-musl on Alpine Linux ... Node.js unofficial-builds publishes linux-arm64-musl binaries since v20.20.1 / v22.21.1 / v24+. Map NVM_ARCH=arm64 to arm64-musl on Alpine so `nvm install` resolves to the correct tarball instead of the glibc-linked arm64 build that won't run against musl. [Tests] `nvm_get_arch`: expect arm64-musl on Alpine Co-authored-by: Jesse Zhu <jesse@itjesse.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>	2026-05-23 01:35:12 +09:00
Jordan Harband	4e48294bd6	[Fix] nvm_ls_cached: include source-cached and io.js artifacts ... `--offline` version resolution could only see cached node binaries: `nvm_ls_cached` listed `.cache/bin` with a `node-` prefix filter, so cached source tarballs, and everything io.js, could never resolve offline. List both cache kinds, for both flavors, and update the pinned test expectations to match.	2026-07-09 22:35:15 -07:00
Mathew DodgsonandJordan Harband	3a8b51c46c	[Fix] auth header: Add all valid base64 chars to sanitize function	2026-05-25 11:14:39 +10:00
Jake LodwickandJordan Harband	0a9dead76d	[Refactor] nvm_alias: one-pass trailing whitespace strip ... Replace the per-character trailing-whitespace loop with a one-pass parameter expansion, per review.	2026-05-05 23:32:58 -04:00
Jake LodwickandJordan Harband	304a22ad59	[Refactor] nvm_alias: use [[:space:]] instead of literal tab ... [Tests] `nvm_alias`: add edge-case tests for hostile file content	2026-02-18 14:29:52 -07:00
Jake LodwickandJordan Harband	d22bf7f538	[Refactor] nvm_alias, nvm_resolve_alias: use builtins ... [Tests] `nvm_alias`, `nvm_resolve_alias`: add edge-case tests nvm_alias() used a sed/awk pipeline to strip comments and blank lines from alias files that almost always contain a single word. A while-read loop with parameter expansion does the same filtering more directly. nvm_resolve_alias() piped nvm_alias through head and tail to extract one line, and used printf/grep for cycle detection. Parameter expansion and a case statement replace both without the extra plumbing. All replacements are POSIX (read -r, case, IFS=, parameter expansion). As a side effect, this also removes 4 external process invocations during shell init. [Fix] `nvm_resolve_alias`: detect cycles via newline-anchored `case` The original commit referenced above changed SEEN_ALIASES from `\n`-delimited storage (interpreted by `printf '%b' | nvm_grep -e "^${name}$"`) to space- delimited but left the line-anchored grep in place — without newlines in the haystack the anchored pattern can never match, so cycles never break. Switch to literal-newline storage and a `case` pattern anchored on those newlines. Newline anchoring also handles alias names containing spaces, which token-based patterns false-positive on (e.g. lookup of `bar` matches substring " bar " inside " foo bar midway " when the chain visits the multi-token alias `foo bar`). New test file covers self-loop, multi-hop loop, cycle through a space-bearing alias name, and a non-cycle through a space-bearing alias name. Existing `test/fast/Aliases/circular/` fixtures continue to pass.	2026-02-17 13:44:31 -07:00
Jordan Harband	dd61ae4bc8	[Robustness] nvm_alias: explicitly succeed when the alias file is unreadable ... The sed/awk pipeline exits with awk's status, so an existing-but-unreadable alias file produces empty output with status 0 - but only by accident, alongside sed's read error on stderr. Make that contract explicit: a nonzero status here would flip `nvm_ensure_default_set` from "default is already set" to recreating it, silently overwriting a write-only default alias.	2026-07-09 15:43:56 -07:00
jinhyuk9714andJordan Harband	82315e2b18	[Fix] Parse commented nvmrc content in nvm_ls ... Fixes #3761 Signed-off-by: jinhyuk9714 <jinhyuk9714@gmail.com>	2026-06-09 00:21:55 +09:00
Yinan QinandJordan Harband	ab77712867	[New] install: add support for loongarch64 architecture	2025-10-25 19:19:05 +08:00
ryenusandJordan Harband	0c1243a7ea	[Fix] bypass aliased curl ... Closes #2932	2023-01-10 15:32:47 +08:00
Jordan Harband	9142a92cdc	[Fix] nvm_download, nvm_get_latest, install: only select a downloader that exists as an executable ... `nvm_has` matches shell functions and aliases, but downloads now run via `command`, which skips them - a `curl` shell function with no curl binary on the PATH would select the curl path and fail with exit 127, instead of falling back to an available wget executable. The new `nvm_has_executable` helper resolves names the same way `command` does, so downloader selection and execution agree.	2026-07-08 13:03:16 -07:00
Jordan Harband	04fef13bdc	[Fix] use command to bypass curl/wget shell functions and aliases ... zsh (and interactive bash with `expand_aliases`) bakes a preexisting `curl` alias into nvm's function bodies at source time, and shell functions named `curl`/`wget` shadow the binaries at call time - either one breaks downloads. Prefixing invocations with `command` bypasses both: here, `nvm_download`'s dispatch, `nvm_curl_version`, `nvm_curl_libz_support`, and the wget branch of `nvm_get_latest`; the remaining bare `curl` invocations in `nvm_get_latest` and the install script are prefixed in a followup commit. The tests that previously mocked curl/wget as shell functions now install fake executables on PATH instead, via a shared `make_fake_curl` helper in `test/common.sh`, and a new test asserts the bypass. Refs #2923	2026-07-08 13:02:41 -07:00
Rahul BeniwalandJordan Harband	cb0e0ba8ed	[Fix] install: use darwin-x64 for all binary on mac for node < v16	2025-11-16 14:48:10 +05:30
Jordan Harband	ce15734300	[Fix] nvm install: migrate packages/set alias when target is already installed ... When `nvm install <target>` found that `<target>` was already installed, the post-`nvm use` steps (`--reinstall-packages-from`, default packages, and `--alias`/`--default`) were gated on `[ $EXIT_CODE -ne 0 ]`. Since that branch is only entered when `nvm use` succeeded (EXIT_CODE == 0), those conditions were always false, so the steps were silently skipped. The fresh-install branch correctly uses `-eq 0`; mirror that here so `--reinstall-packages-from` actually migrates global packages (and the alias/default get set) when the target version already exists. Includes a regression test covering the already-installed path. Fixes #3858	2026-06-29 16:39:19 -05:00
Jordan Harband	a6ec739430	[Docs] document current and clarify .nvmrc fallback in help/README ... - Help text for `nvm install`/`use`/`exec`/`run`/`which` now ends with "Uses .nvmrc if version is omitted; otherwise errors." so it's clear that omitting the version is not a free fallback. - Help signatures for `use`/`exec`/`run` now show `[current | <version>]` to mirror `nvm which` and document that `current` is accepted. - `nvm current` description now spells out that it resolves via `$PATH` and is not affected by `.nvmrc`. - README: add `current` to the list of special aliases, with the same caveat. The `.nvmrc` section now states that `nvm use`/`install`/`which` exit with status 127 when neither a version nor an `.nvmrc` resolves, notes the (current) `exec`/`run` fallback as undefined behavior, and points readers at `current` for the explicit "active node" use case. Refs #3755	2026-06-10 15:16:24 -07:00
Jordan Harband	718e880890	[Fix] focused error on missing/invalid args for several subcommands ... Previously a number of subcommands dumped the entire `nvm --help` output (~100 lines) when arguments were missing or invalid, drowning the real error. Replace each dump with a short, command-specific usage block that names the expected syntax and points to `nvm --help` for full help. The exit code (127) is unchanged. Affected subcommands: - `nvm install` (no version + no .nvmrc) - `nvm use` (version unresolvable) - `nvm run` (no version + no .nvmrc) - `nvm which` (no version + no .nvmrc) - `nvm cache` (unknown subcommand) - `nvm uninstall` (wrong arg count) - `nvm unalias` (wrong arg count) - `nvm install-latest-npm` (wrong arg count) - `nvm reinstall-packages` / `nvm copy-packages` (wrong arg count) The catch-all unknown-subcommand handler still dumps full help, since in that case the user has no narrower context to be reminded about. Refs #3755	2026-06-10 15:16:23 -07:00
Jordan Harband	ed4dbdfdd5	[Fix] nvm_rc_version: clarify error when no version and no .nvmrc ... Previously the message read "No .nvmrc file found", which obscured the fact that the user also did not pass a version. The new wording names both halves of the actual problem. Refs #3755	2026-06-10 15:16:23 -07:00
Jordan Harband	a9933f77a6	[Fix] nvm exec/nvm run: warn when no version and no .nvmrc ... Currently these commands silently fall back to the active node version when neither a version argument nor an `.nvmrc` resolves, making them invisibly dependent on shell state and impossible to script predictably (see #3755). Print a stderr deprecation warning in this case (suppressed by `--silent`) and continue with the active node version, so existing callers keep working. The follow-up change will turn this into a hard error; pass `current` explicitly (e.g. `nvm exec current node ...`) to silence the warning and lock in the new behavior now. Refs #3755	2026-06-10 15:16:23 -07:00
Jordan Harband	1889911f08	v0.40.5	2026-06-04 09:33:05 -07:00
Jordan Harband	70fb4ede6b	[Fix] nvm_download_artifact: reject version strings with disallowed characters ... The mirror-supplied (untrusted) version flows into download URLs, filesystem paths, and the checksum awk match. Reject any version outside the node/io.js grammar (`[0-9A-Za-z._+-]`) before it is used. A blocklist of metacharacters is used rather than a strict semver allowlist so RCs, nightlies, v8-canary, and io.js versions still install. Completes the remediation of GHSA-3c52-35h2-gfmm.	2026-06-03 13:09:07 -07:00
Jordan Harband	90bb88748b	[Fix] nvm_get_checksum: pass the tarball name to awk as data, not program text ... The awk program string-interpolated the slug (which embeds the untrusted, mirror-supplied version) into its source, so a crafted version such as `v1"==$2){system("touch${IFS}/tmp/x")}#` was executed by awk's `system()`. Pass the value via `-v tarball=...` so awk treats it as data and never as code. See GHSA-3c52-35h2-gfmm (a second injection sink fed by the same untrusted version field that `nvm_download`'s eval was; the source-install path reaches this during a normal `nvm install <version>`).	2026-06-03 13:11:26 -07:00
Jordan Harband	6d870d182c	[Fix] nvm_download: avoid eval so mirror-supplied version strings can't inject commands ... `nvm_download` built a curl/wget command string and ran it with `eval`. The download URLs embed the version string taken from the mirror's `index.tab`, which is untrusted. Wrapping each argument in double quotes inside the `eval` does not prevent command substitution, so a version field such as `v1$(touch /tmp/proof)` was executed by the shell. This bypassed the earlier quoting hardening in 0ce8f5a. Pass every argument as a literal argv element instead of constructing a string for `eval`, on both the curl and wget paths, so URL arguments are never re-parsed by the shell. The wget flag translation is now done per-argument with a POSIX `set --` loop rather than `sed` over the joined string. The auth header is sanitized and added once, before invoking the downloader.	2026-06-02 17:41:44 -07:00
Jordan Harband	d264b796a3	[Fix] nvm_download: send a well-formed Authorization header on the wget path ... The wget path passed `NVM_AUTH_HEADER` as the raw header line (e.g. `--header "Bearer secret-token"`), omitting the `Authorization:` header name that the curl path includes. Per the documented usage (`NVM_AUTH_HEADER="Bearer secret-token"`) the value is the credential, so wget was sending a malformed header. Prefix it with `Authorization: ` to match the curl path.	2026-06-02 17:40:50 -07:00
Jordan Harband	53855417eb	[Fix] avoid an unbound variable ... Fixes #3820	2026-05-15 23:08:37 -07:00
Jordan Harband	1f70aea0b0	[Docs] fix --offline help line alignment	2026-05-05 17:16:31 -07:00
Elan RuusamäeandJordan Harband	083bb94f25	[Fix] Add local for sanitized_header	2026-05-03 21:16:14 +03:00
Dick MarinusandJordan Harband	790ffd2682	[Fix] fix same owner for root when install from binary ... GNU Tar has `--preserve-permissions` as a default enabled when executed as the superuser (root). This will cause the binaries to be installed using the permissions (owner and group) as defined in the tarball. The argument `--no-same-owner` prevents this and will install the binaries as the effective owner/group just like when nvm is executed as a non superuser. Updated the install from binary test from the installation_node test suite because this test is run in a docker container as root. Without --no-same-owner this test will fail beause the binaries of node v0.10.7 are owned by isaacs/admin in the tarball.	2026-05-05 15:40:32 -07:00
Jordan Harband	d200a21559	[Fix] nvm_normalize_lts: only reject uppercase for LTS names, not regular aliases ... The lowercase check was in the `*` catch-all branch of the `case` statement, rejecting any alias name with uppercase characters. This prevented creating or reading uppercase aliases like `TESTY`. The check should only apply to `lts/*` patterns, since LTS codenames are always lowercase. Fixes #3764. Bug introduced in https://github.com/nvm-sh/nvm/commit/9fb9dec710e2c8d3aecb24c2a7c9f9fb45b1435b as part of fixing #3417.	2026-03-26 10:18:40 -07:00
Peter Dave HelloandJordan Harband	59d4ea8f3e	[Docs] Clean up wording in docs and shell comments ... Adjust a few spelling, grammar, and naming inconsistencies in the docs and related shell comments without changing behavior.	2026-03-23 23:48:23 +08:00
Jordan Harband	018958cc47	[Fix] nvm which: show alias name in infinite loop error message ... `${2}` was empty because positional parameters had been consumed by `shift` in the argument parsing loop. Use `${provided_version}` which holds the resolved alias name. Bug introduced in https://github.com/nvm-sh/nvm/commit/1c00753fd9c3ae5e0bb3f4992c5e283ef5bf5085.	2026-03-14 14:37:57 -07:00
Jordan Harband	33fda56d2a	[Fix] nvm uninstall: fix alias cleanup glob expansion ... The `*` glob was inside double quotes, preventing shell expansion. `nvm_grep -l` received a literal `*` filename instead of the list of alias files, so aliases pointing to uninstalled versions were never cleaned up. Bug introduced in https://github.com/nvm-sh/nvm/commit/7807a9f09e54a14f9b493c6eeda0022489cda496.	2026-03-14 14:34:06 -07:00
Jordan Harband	32863e1052	[Fix] nvm debug: use default empty values for potentially unset variables ... These variables may be unset, which would cause errors in shells with `set -u` (nounset) enabled. Bugs introduced in https://github.com/nvm-sh/nvm/commit/b805de80cb8058f09fecb11786d4d2aec0dac35c and https://github.com/nvm-sh/nvm/commit/49e446dac18ce8b1267107849e6be6fe99390543.	2026-03-14 14:33:35 -07:00
Jordan Harband	53e6244aa6	[Fix] nvm_iojs_version_has_solaris_binary: fix comparison to detect non-iojs versions ... Missing `_` prefix on the right side of the comparison meant the guard clause that rejects non-iojs versions almost never matched, allowing non-iojs versions to fall through. Bug introduced in https://github.com/nvm-sh/nvm/commit/2d692d9d7863844d9e5c499faf423b350235f72d / #854.	2026-03-14 14:30:54 -07:00
Jordan Harband	bda39c7c04	[Fix] nvm_download_artifact: fix error propagation from subshells ... `return` inside `(...)` subshells only exits the subshell, not the calling function. Errors in mkdir, download, and checksum verification were silently ignored. Use `{ ...; }` brace groups instead. Bug introduced in https://github.com/nvm-sh/nvm/commit/ba3ad8e460b88aab281d203276b354ce3c9df52f.	2026-03-14 14:30:31 -07:00
Jordan Harband	05d784772c	[Fix] nvm_install_binary: return failure when binary download fails with -b ... When `nosource=1` (the `-b` flag) and binary download fails, the function returned 0 (success) instead of a non-zero exit code, masking the installation failure. Bug introduced in https://github.com/nvm-sh/nvm/commit/4fdef427e4b1d563570ba5992bdbe7d7e23f025b / #2439.	2026-03-14 14:29:56 -07:00
Jordan Harband	39e71eab49	[Fix] nvm_get_arch: only apply musl suffix on x64 Alpine ... Alpine detection unconditionally set `x64-musl` regardless of actual architecture, which would be incorrect on ARM-based Alpine containers. Bug introduced in https://github.com/nvm-sh/nvm/commit/ef7fc2f2c06ad75fe7fbabf28d427561ae7b007d / #3212. Fixes #3616.	2026-03-14 12:53:14 -07:00
Jordan Harband	a5de7236d6	[Fix] nvm_get_arch: add command prefix to uname call ... Other `uname` calls in the file use `command uname` to bypass any user aliases or functions. This one was missing it. Bug introduced in https://github.com/nvm-sh/nvm/commit/779a34e6a9adcb6528e63d595a7a8838747e7915 / #2469.	2026-03-14 10:16:48 -07:00
Jordan Harband	d2fca5f0ec	[Fix] nvm_resolve_local_alias: avoid using variable as printf format string ... Using a variable as the format string means `%` characters in alias names would be interpreted as format specifiers. Use `%b` format with the variable as an argument to safely interpret `\n` escapes. Bug introduced in https://github.com/nvm-sh/nvm/commit/9b91734f0b6a210f0c6655b0cd25ea288d9ae376.	2026-03-14 10:16:25 -07:00
Jordan Harband	3c48015986	[Fix] nvm_get_mirror: fix awk URL validation to actually reject invalid URLs ... The awk expression `$0 ~ "regex"` as a bare statement in the action block evaluates the match but doesn't affect the exit code. awk always prints the line and exits 0, making the validation a no-op. Bug introduced in https://github.com/nvm-sh/nvm/commit/b1fa143dd8cbebd9847972c08fb383646ca00642.	2026-03-14 09:40:43 -07:00
Jordan Harband	a937cb595e	[Fix] nvm_ls_remote_combined: propagate iojs remote listing failures ... `return $A || $B` only evaluates the first argument, since `return` always succeeds. The io.js exit code was never checked, silently swallowing remote listing failures. Bug introduced in https://github.com/nvm-sh/nvm/commit/ea127846290b1126556e256031383d171a4e38d8 / #616.	2026-03-14 09:39:20 -07:00
Jordan Harband	6f428a10bb	[Fix] nvm install: fix nvm err typo to nvm_err for -s/-b conflict ... The error message for using `-s` and `-b` together was calling `nvm err` (invoking nvm with subcommand "err") instead of the `nvm_err` helper function, causing the error message to never be displayed and instead showing the help text with exit code 127. Bug introduced in https://github.com/nvm-sh/nvm/commit/4fdef427e4b1d563570ba5992bdbe7d7e23f025b / #2439	2026-03-14 09:38:04 -07:00
Jordan Harband	ef1620361a	[Refactor] nvm_rc_version: use fd 3 instead of exported env var for multiple return	2026-03-12 15:32:17 -04:00
Jordan Harband	a27a8b7da8	[Fix] nvm alias: fix colors not showing by default ... Colors were lost because `nvm_has_colors` checks `[ -t 1 ]`, which is false inside the `(...) | sort` pipeline in `nvm_list_aliases`. Evaluate `nvm_has_colors` before the pipe and propagate via `NVM_HAS_COLORS`, matching the approach used by `nvm_print_versions`. Bug introduced in https://github.com/nvm-sh/nvm/commit/35212c134652197c779dffd42b9567a270355987.	2026-03-13 16:13:41 -04:00
Jordan Harband	59bd32be6b	[New] nvm install --offline: install from cache without network access ... Add `--offline` flag to `nvm install` that resolves versions using only locally installed versions and cached downloads. No network calls are made. New helper functions `nvm_ls_cached` and `nvm_offline_version` scan `$NVM_DIR/.cache/bin/` for previously downloaded tarballs. In offline mode, `nvm_download_artifact` returns cached tarballs directly without checksum verification or download attempts. The curl/wget requirement is skipped when `--offline` is set. Supports `--lts` via locally stored LTS alias files.	2026-03-13 16:13:19 -04:00
Jordan Harband	62387b8f92	v0.40.4	2026-01-29 14:12:03 -08:00
Sy2n0andJordan Harband	44e2590cdf	[Fix] sanitize NVM_AUTH_HEADER in wget path	2026-01-09 11:30:14 +09:00