247 Commits

Include renames

Author	SHA1	Message	Date
Jordan Harband	4e48294bd6	[Fix] nvm_ls_cached: include source-cached and io.js artifacts ... `--offline` version resolution could only see cached node binaries: `nvm_ls_cached` listed `.cache/bin` with a `node-` prefix filter, so cached source tarballs, and everything io.js, could never resolve offline. List both cache kinds, for both flavors, and update the pinned test expectations to match.	2026-07-09 22:35:15 -07:00
Jordan Harband	1a39786c8a	[Tests] nvm_offline_version: make it executable; pin nvm_ls_cached cache visibility ... The test was born without its executable bit, and urchin silently skips non-executable files, so it has never run. Also pin what `nvm_ls_cached` can currently see: only bin-cached node artifacts - bin-cached io.js, and src-cached anything, are invisible to it, and thus to `--offline` version resolution.	2026-07-09 22:35:15 -07:00
Mathew DodgsonandJordan Harband	3a8b51c46c	[Fix] auth header: Add all valid base64 chars to sanitize function	2026-05-25 11:14:39 +10:00
Jordan Harband	21d33ef04a	[Tests] nvm_ls handles hash in pattern: fix cleanup, isolate NVM_DIR, cover the sed path ... - `cleanup` unset TEST_DIR before `rm -rf "${TEST_DIR-}"`, so the temp dir (with an executable fake `node`) was never removed, and urchin executes any executable file it finds under the test dir on the next local run. - the preexisting `foo#bar` assertions ran against the ambient NVM_DIR; now that `#` patterns comment-strip to `foo`, a real local alias named `foo` would resolve and break them, so all assertions now run against an isolated NVM_DIR. - the multiline content used a full x.y.z version, which takes nvm_ls's explicit-version fast path and never reaches the find/sed pipeline where the newline actually broke sed; a partial version exercises that path, and matching on "unterminated" covers both the BSD and GNU sed error wordings.	2026-07-08 23:14:23 -07:00
jinhyuk9714andJordan Harband	82315e2b18	[Fix] Parse commented nvmrc content in nvm_ls ... Fixes #3761 Signed-off-by: jinhyuk9714 <jinhyuk9714@gmail.com>	2026-06-09 00:21:55 +09:00
Yinan QinandJordan Harband	ab77712867	[New] install: add support for loongarch64 architecture	2025-10-25 19:19:05 +08:00
Jordan Harband	9142a92cdc	[Fix] nvm_download, nvm_get_latest, install: only select a downloader that exists as an executable ... `nvm_has` matches shell functions and aliases, but downloads now run via `command`, which skips them - a `curl` shell function with no curl binary on the PATH would select the curl path and fail with exit 127, instead of falling back to an available wget executable. The new `nvm_has_executable` helper resolves names the same way `command` does, so downloader selection and execution agree.	2026-07-08 13:03:16 -07:00
Jordan Harband	04fef13bdc	[Fix] use command to bypass curl/wget shell functions and aliases ... zsh (and interactive bash with `expand_aliases`) bakes a preexisting `curl` alias into nvm's function bodies at source time, and shell functions named `curl`/`wget` shadow the binaries at call time - either one breaks downloads. Prefixing invocations with `command` bypasses both: here, `nvm_download`'s dispatch, `nvm_curl_version`, `nvm_curl_libz_support`, and the wget branch of `nvm_get_latest`; the remaining bare `curl` invocations in `nvm_get_latest` and the install script are prefixed in a followup commit. The tests that previously mocked curl/wget as shell functions now install fake executables on PATH instead, via a shared `make_fake_curl` helper in `test/common.sh`, and a new test asserts the bypass. Refs #2923	2026-07-08 13:02:41 -07:00
Rahul BeniwalandJordan Harband	cb0e0ba8ed	[Fix] install: use darwin-x64 for all binary on mac for node < v16	2025-11-16 14:48:10 +05:30
Jordan Harband	ed4dbdfdd5	[Fix] nvm_rc_version: clarify error when no version and no .nvmrc ... Previously the message read "No .nvmrc file found", which obscured the fact that the user also did not pass a version. The new wording names both halves of the actual problem. Refs #3755	2026-06-10 15:16:23 -07:00
Jordan Harband	70fb4ede6b	[Fix] nvm_download_artifact: reject version strings with disallowed characters ... The mirror-supplied (untrusted) version flows into download URLs, filesystem paths, and the checksum awk match. Reject any version outside the node/io.js grammar (`[0-9A-Za-z._+-]`) before it is used. A blocklist of metacharacters is used rather than a strict semver allowlist so RCs, nightlies, v8-canary, and io.js versions still install. Completes the remediation of GHSA-3c52-35h2-gfmm.	2026-06-03 13:09:07 -07:00
Jordan Harband	90bb88748b	[Fix] nvm_get_checksum: pass the tarball name to awk as data, not program text ... The awk program string-interpolated the slug (which embeds the untrusted, mirror-supplied version) into its source, so a crafted version such as `v1"==$2){system("touch${IFS}/tmp/x")}#` was executed by awk's `system()`. Pass the value via `-v tarball=...` so awk treats it as data and never as code. See GHSA-3c52-35h2-gfmm (a second injection sink fed by the same untrusted version field that `nvm_download`'s eval was; the source-install path reaches this during a normal `nvm install <version>`).	2026-06-03 13:11:26 -07:00
Jordan Harband	6d870d182c	[Fix] nvm_download: avoid eval so mirror-supplied version strings can't inject commands ... `nvm_download` built a curl/wget command string and ran it with `eval`. The download URLs embed the version string taken from the mirror's `index.tab`, which is untrusted. Wrapping each argument in double quotes inside the `eval` does not prevent command substitution, so a version field such as `v1$(touch /tmp/proof)` was executed by the shell. This bypassed the earlier quoting hardening in 0ce8f5a. Pass every argument as a literal argv element instead of constructing a string for `eval`, on both the curl and wget paths, so URL arguments are never re-parsed by the shell. The wget flag translation is now done per-argument with a POSIX `set --` loop rather than `sed` over the joined string. The auth header is sanitized and added once, before invoking the downloader.	2026-06-02 17:41:44 -07:00
Jordan Harband	d264b796a3	[Fix] nvm_download: send a well-formed Authorization header on the wget path ... The wget path passed `NVM_AUTH_HEADER` as the raw header line (e.g. `--header "Bearer secret-token"`), omitting the `Authorization:` header name that the curl path includes. Per the documented usage (`NVM_AUTH_HEADER="Bearer secret-token"`) the value is the credential, so wget was sending a malformed header. Prefix it with `Authorization: ` to match the curl path.	2026-06-02 17:40:50 -07:00
Jordan Harband	dd13968c1e	[Tests] reduce CI flakiness from transient Docker registry failures ... Container-based suites and the `nvm_download` httpbin check hard-fail whenever DockerHub is briefly unreachable (observed: `dial tcp ...:443: connect: connection refused` while pulling images), even though the change under test is fine. This is unrelated to any test logic. - tests-xenial / tests-installation-node: retry the `docker pull` up to 5 times before `docker run`, mirroring the existing apt-get retry - `nvm_download` test: retry the httpbin pull and skip the auth-header checks (rather than fail) when the image cannot be pulled or run, and make cleanup tolerant of a missing container.	2026-06-03 13:12:31 -07:00
Jordan Harband	53855417eb	[Fix] avoid an unbound variable ... Fixes #3820	2026-05-15 23:08:37 -07:00
Андрій ШовкошитнийandJordan Harband	20d52b6419	[tests] remove double-substitution in assert_ok and assert_not_ok ... Co-authored-by: Андрій Шовкошитний <198119344+enlightened88@users.noreply.github.com> Co-authored-by: Jordan Harband <ljharb@gmail.com>	2026-04-23 17:16:32 +03:00
Jordan Harband	3e37cfb9c4	[Tests] fix 4 test failures ... - `nvm-exec` test: expect "Found .nvmrc" message in output, since `nvm_rc_version` now outputs it to stdout via fd 3 redirection (ef162036) - `nvm_install_binary_nosource`: fix exit code capture by running the command directly instead of inside a subshell with `echo $?` (05d78477) - `nvm_iojs_version_has_solaris_binary`: bare versions like `v3.3.1` (without `iojs-` prefix) are node versions and should be rejected. The old tests relied on the buggy comparison that let them through (53e6244a) - `nvm_get_arch_unofficial`: copy `uname` into the chroot. The old test passed only because the unconditional `NVM_ARCH=x64-musl` masked the missing binary, but the `case` fix now requires a real arch to match (39e71eab)	2026-03-24 12:44:21 -07:00
Jordan Harband	53e6244aa6	[Fix] nvm_iojs_version_has_solaris_binary: fix comparison to detect non-iojs versions ... Missing `_` prefix on the right side of the comparison meant the guard clause that rejects non-iojs versions almost never matched, allowing non-iojs versions to fall through. Bug introduced in https://github.com/nvm-sh/nvm/commit/2d692d9d7863844d9e5c499faf423b350235f72d / #854.	2026-03-14 14:30:54 -07:00
Jordan Harband	bda39c7c04	[Fix] nvm_download_artifact: fix error propagation from subshells ... `return` inside `(...)` subshells only exits the subshell, not the calling function. Errors in mkdir, download, and checksum verification were silently ignored. Use `{ ...; }` brace groups instead. Bug introduced in https://github.com/nvm-sh/nvm/commit/ba3ad8e460b88aab281d203276b354ce3c9df52f.	2026-03-14 14:30:31 -07:00
Jordan Harband	05d784772c	[Fix] nvm_install_binary: return failure when binary download fails with -b ... When `nosource=1` (the `-b` flag) and binary download fails, the function returned 0 (success) instead of a non-zero exit code, masking the installation failure. Bug introduced in https://github.com/nvm-sh/nvm/commit/4fdef427e4b1d563570ba5992bdbe7d7e23f025b / #2439.	2026-03-14 14:29:56 -07:00
Jordan Harband	39e71eab49	[Fix] nvm_get_arch: only apply musl suffix on x64 Alpine ... Alpine detection unconditionally set `x64-musl` regardless of actual architecture, which would be incorrect on ARM-based Alpine containers. Bug introduced in https://github.com/nvm-sh/nvm/commit/ef7fc2f2c06ad75fe7fbabf28d427561ae7b007d / #3212. Fixes #3616.	2026-03-14 12:53:14 -07:00
Jordan Harband	3c48015986	[Fix] nvm_get_mirror: fix awk URL validation to actually reject invalid URLs ... The awk expression `$0 ~ "regex"` as a bare statement in the action block evaluates the match but doesn't affect the exit code. awk always prints the line and exits 0, making the validation a no-op. Bug introduced in https://github.com/nvm-sh/nvm/commit/b1fa143dd8cbebd9847972c08fb383646ca00642.	2026-03-14 09:40:43 -07:00
Jordan Harband	a937cb595e	[Fix] nvm_ls_remote_combined: propagate iojs remote listing failures ... `return $A || $B` only evaluates the first argument, since `return` always succeeds. The io.js exit code was never checked, silently swallowing remote listing failures. Bug introduced in https://github.com/nvm-sh/nvm/commit/ea127846290b1126556e256031383d171a4e38d8 / #616.	2026-03-14 09:39:20 -07:00
Jordan Harband	6f428a10bb	[Fix] nvm install: fix nvm err typo to nvm_err for -s/-b conflict ... The error message for using `-s` and `-b` together was calling `nvm err` (invoking nvm with subcommand "err") instead of the `nvm_err` helper function, causing the error message to never be displayed and instead showing the help text with exit code 127. Bug introduced in https://github.com/nvm-sh/nvm/commit/4fdef427e4b1d563570ba5992bdbe7d7e23f025b / #2439	2026-03-14 09:38:04 -07:00
Jordan Harband	59bd32be6b	[New] nvm install --offline: install from cache without network access ... Add `--offline` flag to `nvm install` that resolves versions using only locally installed versions and cached downloads. No network calls are made. New helper functions `nvm_ls_cached` and `nvm_offline_version` scan `$NVM_DIR/.cache/bin/` for previously downloaded tarballs. In offline mode, `nvm_download_artifact` returns cached tarballs directly without checksum verification or download attempts. The curl/wget requirement is skipped when `--offline` is set. Supports `--lts` via locally stored LTS alias files.	2026-03-13 16:13:19 -04:00
Jordan Harband	14d01c6877	[Tests] add try/try_err helpers; convert tests to use them ... Add `try` and `try_err` helper functions to `test/common.sh` that capture stdout/stderr and exit code from a single invocation, eliminating duplicate command executions in tests. Convert all existing tests that used the `OUTPUT`/`EXIT_CODE` double-invocation pattern to use the new helpers. Also fixes a pre-existing bug in the `nvm_die_on_prefix` test where ASCII apostrophes were used instead of U+2019 to match nvm.sh output.	2026-03-13 15:26:07 -04:00
Sy2n0andJordan Harband	44e2590cdf	[Fix] sanitize NVM_AUTH_HEADER in wget path	2026-01-09 11:30:14 +09:00
Peter Dave HelloandJordan Harband	29a652f90f	[patch] show system Node.js version in nvm ls ... Normalize `nvm_version` output when `nvm_ls` returns "system vX" so alias and .nvmrc resolutions treat system correctly. Add fast tests for system alias behavior in `nvm ls`, `nvm use`, and `nvm which`.	2026-01-25 18:19:50 +08:00
Jordan Harband	4c3edc5e56	[actions] migrate Travis CI tests to GitHub Actions	2026-01-27 10:31:07 -08:00
Jordan Harband	35212c1346	[Fix] nvm_has_colors: also check if stdout is a terminal	2026-01-27 10:31:07 -08:00
Jordan Harband	d2f93c1c8e	[Tests] mock node in nvm_die_on_prefix test	2026-01-26 22:34:24 -08:00
Jordan Harband	c451e7a4c8	[Tests] set $_ before sourcing nvm.sh in fast tests ... nvm.sh uses `NVM_SCRIPT_SOURCE="$_"` to detect its source location. Adding `: nvm.sh` before each source line ensures `$_` is set correctly, preventing breakage when the previous command (e.g., `set -ex`) overwrites it.	2026-01-26 21:41:57 -08:00
Jordan Harband	38ffc713a7	[Fix] nvm_get_default_packages: use portable awk patterns ... Replace POSIX `[[:space:]]` character class with `[ \t]` for mawk compatibility on Ubuntu 16.04.	2026-01-26 16:59:11 -08:00
Jordan Harband	aa1d829102	[Fix] nvm_install_source: explicitly set SHELL=/bin/sh for make ... Old Node.js versions have Makefiles with unquoted glob patterns like `rm -f *.o` that fail in zsh's strict glob mode. By passing SHELL=/bin/sh to make, we ensure POSIX-compliant shell behavior regardless of what shell nvm is running in.	2026-01-26 15:07:01 -08:00
Noritaka KobayashiandJordan Harband	4d364c2e7b	[readme] fix typo	2025-10-18 10:28:48 +09:00
Rahul BeniwalandJordan Harband	81f13638d7	[Fix] Reject bare LTS codenames in nvm install ... Previously, `nvm install Argon` would succeed by matching the LTS name in the version description (e.g., "v4.9.1 (Latest LTS: Argon)"), but `nvm uninstall Argon` would fail because "Argon" is not a valid alias or not a valid version. Changes: - Added pattern matching check in nvm_remote_version (nvm.sh:785-791) - Skips check for implicit aliases (node, stable, etc.) to preserve existing functionality - Added unit tests to verify LTS names are rejected while version numbers still work After this fix: - `nvm install Argon` → fails (use `nvm install lts/argon` instead) - `nvm install 4` → still works - `nvm install node` → still works - `nvm install lts/argon` → still works This makes install and uninstall behavior consistent. Fixes #3474.	2025-11-24 21:57:39 +05:30
Jordan Harband	26066c10f4	[Fix] prevent sed errors when pattern contains # ... When `.nvmrc` or alias files contained comments (lines with `#`), the `#` character could end up in the search pattern passed to sed, causing "unterminated regular expression" errors because `#` is used as the sed address delimiter. This commit fixes the issue in two places: 1. `nvm_alias`: Strip comments from alias file contents before returning them, and trim trailing whitespace 2. `nvm_ls`: Escape `#` characters in SEARCH_PATTERN so they're treated as literal characters in the sed address Fixes #3761	2026-01-19 22:58:43 -08:00
Jordan Harband	1be4257e96	[Tests] update mocks	2024-10-31 14:23:36 -07:00
Jordan Harband	51ea809d63	[Tests] ensure that unit tests use only mocked LTS names	2024-10-30 23:41:50 -07:00
Jordan Harband	da2720a429	[Fix] nvm ls, nvm alias, nvm install: error when an LTS name is invalid	2024-09-04 13:55:11 -07:00
Jordan Harband	9fb9dec710	[Fix] nvm_normalize_lts: error when an LTS name is not lowercase ... Fixes #3417	2024-09-04 13:54:41 -07:00
Jordan Harband	9a28dbd394	[actions] use node/install instead of node/run	2024-08-28 11:28:52 -07:00
Jordan Harband	ff7634577b	[Tests] fix broken tests exposed by 863bd63 ... Leaves 2 non-executable, + some TODOs	2024-08-27 12:46:40 -07:00
Jordan Harband	0ce8f5a52f	[Fix] nvm_download: ensure all args are quoted ... Fixes #3411.	2024-08-20 22:33:38 -07:00
Jordan Harband	863bd63cfa	[Tests] set proper permissions on test files	2024-08-23 17:23:12 -07:00
Jordan Harband	14acd3dcdd	[Fix] nvm install -b: do not attempt to download source on a failed binary download with -b ... Fixes #3399	2024-08-01 10:35:37 -07:00
Jordan Harband	271720ebfc	[Fix] nvm install -b: when no binary is available, fail and output a clear message	2024-08-01 13:57:22 -07:00
Jordan Harband	423ee82b4c	[Tests] fix nvm ls-remote unit test	2024-08-01 10:22:28 -07:00
Jordan Harband	87a709741f	[Fix] nvm_get_default_packages: use awk for more reliable file processing ... See https://github.com/nvm-sh/nvm/commit/db19450caafb37734a3302b24ac9fe2cde40638d Fixes #3382	2024-07-28 10:02:08 -07:00