eeymoo/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-07-18 12:58:21 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity
2,269 Commits 20 Branches 105 Tags
fix-nvmrc-comment-hash
Commit Graph
2269 Commits
This Branch
This Branch
All Branches
Author SHA1 Message Date
ElletandJordan Harband 925cff2c78 [readme] update M1 to “Apple Silicon” because of M2 and M3; fix typos 2023-12-01 05:56:48 +03:00
Jordan Harband b1fa143dd8 [Fix] nvm_get_mirror: ensure only a valid URL is allowed 2023-12-02 14:44:46 -08:00
Jordan Harband cc765cc000 [Fix] avoid overridden hash 
Fixes #3239
 2023-11-24 20:42:53 -08:00
Jordan Harband 99646ee600 [security] add threat model 2023-11-15 10:10:29 -08:00
Jordan Harband b356fab4b4 [meta] fix gitattributes to properly recognize images as binary 2023-11-22 22:29:01 -08:00
Hao ChengandJordan Harband 064f2597d1 [readme] fix level of headings 2023-11-12 14:18:39 +01:00
Jordan Harband 6b15796f66 [Tests] temporarily allow cygwin tests to fail 2023-12-04 15:49:09 -08:00
Jordan Harband 3e51872b98 [Tests] temporarily allow WSL tests to fail 
See https://github.com/Vampire/setup-wsl/issues/50 / https://github.com/actions/runner-images/discussions/8791
 2023-12-04 13:06:24 -08:00
Jordan Harband 4bdd57ba0f [Fix] install.sh: when NVM_INSTALL_GITHUB_REPO is set, issue a warning 
This should only annoy those testing their PRs; real users should never set this env var
 2023-11-02 21:10:09 -07:00
Jordan Harband d02ddcac2c [Fix] nvm_get_mirror: disallow some non-URL characters 
This should be improved in the future, but is fine for now
 2023-11-01 21:01:28 -07:00
Andrius SolopovasandJordan Harband ef7fc2f2c0 [Fix] nvm_get_arch: proper value for alpine linux 2023-09-30 23:54:11 +01:00
Jordan Harband b64e5474ea [Tests] ensure windows tests install a node that actually works 
- disable failing Alpine tests
 - disable Ubuntu-18.04 tests on node 18+
 - add Ubuntu-20.04 tests
 2023-11-01 16:12:12 -07:00
Jordan Harband 1f970ccb7a [Fix] nvm_normalize_lts: switch from expr to case 
avoids `expr: warning: ^lts/-[1-9][0-9]*: using ^ as the first character of a basic regular expression is not portable; it is ignored`
 2023-11-01 12:24:29 -07:00
Jordan Harband 6743aef70c [New] nvm_resolve_alias: only resolve one line of a multiline alias file 2023-10-23 14:41:14 -07:00
Jordan Harband 10cdda081f [Tests] update test mocks (new LTS, iron) 2023-10-25 15:39:12 -07:00
Jordan Harband 8241287349 [New] aliases: skip leading blank lines in alias file 2023-10-23 14:06:19 -07:00
Jordan Harband 6aeab3349c [Robustness] nvm_list_aliases: avoid overwritten sort 2023-10-23 14:05:37 -07:00
Jordan Harband bfce5889f7 [Test] update test mocks 2023-10-23 14:53:39 -07:00
Justin DhillonandJordan Harband fd412645ca [readme] add section on bare nvm install 2023-10-23 10:25:26 -07:00
Jordan Harband 2426a0c4b2 [security] add prose explaining OpenSSF CII Best Practices badge results 
Fixes https://github.com/openjs-foundation/security-collab-space/issues/35.
 2023-10-20 15:58:27 -07:00
Michael Di PriscoandJordan Harband 8a83b36688 [readme] missing parenthesis 2023-10-06 02:36:26 +02:00
Jordan Harband 414e8d426f [Tests] switch cygwin mirror 2023-10-09 14:50:40 -07:00
zhangdiandianandJordan Harband 1b102ab9a6 [Tests] fix filename typo 
Signed-off-by: zhangdiandian <1635468471@qq.com>
 2023-10-09 07:31:04 +00:00
Peter Dave HelloandJordan Harband d4a733e4d8 [Dockerfile] Remove apt src disabling, no longer needed 2023-09-19 20:03:01 +08:00
NamandJordan Harband 1de3333651 [Dockerfile] [Fix] add missing leading slash in path 2023-09-18 17:42:40 +07:00
Jordan Harband 1eaaada499 [Perf] nvm_check_file_permissions: do not traverse into symlinks 2023-08-25 22:49:41 -07:00
Jordan Harband c92adb3c47 v0.39.5 v0.39.5 2023-08-21 21:10:10 -07:00
Oliver HenshawandJordan Harband 15eba7b7e6 [Fix] nvm_strip_path: Preserve leading/trailing colons 
Path lists in environmental variables often give special meaning to
empty entries (e.g. in PATH or MANPATH). These are represented by
leading or trailing colons, or by doubled colons in the middle of the
list.

Adjust the awk invocation to correctly deal with trailing colons by
printing the separator before every field except the first, and then
printing the final separator that is read from the input - this will
either be a colon or the null string. This preserves leading and
trailing colons in all cases while not adding extra colons in the wrong
place.

Add test to confirm the correct behaviour.

Fixes #3144
 2023-06-21 15:47:52 +01:00
heungjun.parkandJordan Harband a1601eddb8 [readme] add examples of setting specific versions as default 
Co-authored-by: heungjun.park <rockheung@gmail.com>
Co-authored-by: Jordan Harband <ljharb@gmail.com>
 2023-07-20 17:39:37 +09:00
Jordan Harband 324b81a722 [Fix] allow checksums to pass with a leading backslash 
See https://unix.stackexchange.com/a/555061/137489
 2023-08-06 14:51:48 +12:00
Jordan Harband 55075db96d [Tests] add some nvm_do_install tests 2022-12-27 22:57:07 -08:00
Jordan Harband 4618ce0aa1 [Tests] a cleaner name for the windows tests 2022-12-27 22:32:09 -08:00
Jordan Harband 3afdce0a2c [Fix] nvm install-latest-npm: ensure npm 10 does not install on unsupported nodes 
See https://github.com/npm/cli/pull/6674
 2023-07-26 13:21:03 -07:00
Jordan Harband 8fbf8ab694 v0.39.4 v0.39.4 2023-07-24 18:29:54 -07:00
Jordan Harband 4fc91d408c [Dev Deps] update markdown-link-check, semver 2023-07-24 18:24:39 -07:00
Emmanuel OgbiziandJordan Harband f86847fdd2 [readme] add nvshim tool alongside avn 2020-04-15 19:27:44 -04:00
emmanuel-ferdmanandJordan Harband 9a769630d7 [readme] fix typo in resolv.conf filename 
Signed-off-by: emmanuel-ferdman <35470921+emmanuel-ferdman@users.noreply.github.com>
 2023-06-18 15:41:40 +03:00
Augustin MauroyandJordan Harband c26422a03e [readme] Update logo header 2023-06-05 10:34:20 +02:00
milesfrainandJordan Harband 7c3cd81ad9 [readme] Add instructions on how to install without editing shell config 
I had to dig into #2410 to learn about the `PROFILE=/dev/null` technique to install without appending to my shell config. Figured this note would be good to add in the main installation docs.
Also added a note on how to do this as a one-liner which was not obvious for me.
 2023-04-25 13:49:16 -07:00
Deniz Eren EvrendilekandJordan Harband 0ebda7eea3 [meta] Remove unavailable testing script 
Fixes #3104
 2023-05-01 11:23:38 -07:00
DenizandJordan Harband 5410ae57ba [Fix] fix node download link for armv8l 
Fixes #3035
 2023-04-29 16:41:31 -07:00
Spike GrobsteinandJordan Harband 70aa611abc [Fix] nvm exec: no longer error with '-q: invalid option' for zsh users 
the `nvm.sh` file assigns and exports an `NVM_CD_FLAGS` variable if it
was sourced from a zsh shell. the fact that it's exported means that
it'll be assigned in all child processes, including the `nvm-exec`
script, which uses bash as the interpreter.

Bash's `cd` command doesn't have a `-q` flag, so if the `NVM_CD_FLAGS`
is assigned `-q`, the script will error out and incorrectly claim that
the node version isn't installed.

this also manifests itself in the `nvm exec` command.

Example:

```console
$ nvm exec 16.14.0 npm --version
Running node v16.14.0 (npm v8.3.1)
/Users/<ME>/.nvm/nvm.sh: line 28: cd: -q: invalid option
cd: usage: cd [-L|[-P [-e]] [-@]] [dir]
both the tree and the node path are required
N/A: version "v16.14.0 -> N/A" is not yet installed.

You need to run "nvm install v16.14.0" to install it before using it.
```

To address this, we unset the `NVM_CD_FLAGS` at the start of the
`nvm-exec` script, before loading `nvm.sh`.
 2023-04-21 20:40:01 -07:00
Jordan Harband c08b38a2a4 [Fix] nvm_print_npm_version: if npm exists but its node crashes, do not print the npm version 2023-04-28 10:57:57 -07:00
Jordan Harband a07cd41af1 [Fix] nvm_ls_current: when node is present but crashes immediately, echo "none" 2023-04-28 10:55:03 -07:00
JC (Jonathan Chen)andJordan Harband d1a22a63bd [readme] cdnvm function: fix shellcheck errors 
Resolves #3081
 2023-04-09 09:21:56 -04:00
Leo ZlotnikovandJordan Harband 0d9b5c2a00 [Fix] fix directory traversal when workdir path is not readable 2023-04-08 17:24:41 +01:00
Peter Dave HelloandJordan Harband 44e1d9c911 [Dockerfile] Update base image from Ubuntu 20.04 to 22.04, cc #2877 2023-04-06 01:22:10 +08:00
Jordan Harband b1331c20b0 [Tests] add unit tests for nvm_download_artifact 2023-04-06 09:23:33 -07:00
Peter Dave HelloandJordan Harband 766341fca1 [readme] Update Travis CI badge and link url 
travis-ci.org is deprecated and replaced by app.travis-ci.com for a while
 2023-04-03 22:50:48 +08:00
Jordan Harband 946da2e743 [Dev Deps] update markdown-link-check 2023-03-22 16:20:48 -07:00