[Fix] nvm_alias, nvm_ls_remote_index_tab, nvm use: return the exit code of a failed check
`if ! cmd; then return $?` returns the status of the negation, which is 0, so an uppercase LTS name, or an unusable installed version, was reported but still exited successfully.
This commit is contained in:
2 files changed
+47
-8
No files matched your search
@@ -1812,9 +1812,7 @@ nvm_alias() {
|
||||
nvm_err 'An alias is required.'
|
||||
return 1
|
||||
fi
|
||||
if ! ALIAS="$(nvm_normalize_lts "${ALIAS}")"; then
|
||||
return $?
|
||||
fi
|
||||
ALIAS="$(nvm_normalize_lts "${ALIAS}")" || return $?
|
||||
|
||||
if [ -z "${ALIAS}" ]; then
|
||||
return 2
|
||||
@@ -2336,9 +2334,7 @@ $VERSION_LIST
|
||||
EOF
|
||||
|
||||
if [ -n "${LTS-}" ]; then
|
||||
if ! LTS="$(nvm_normalize_lts "lts/${LTS}")"; then
|
||||
return $?
|
||||
fi
|
||||
LTS="$(nvm_normalize_lts "lts/${LTS}")" || return $?
|
||||
LTS="${LTS#lts/}"
|
||||
fi
|
||||
|
||||
@@ -5102,8 +5098,8 @@ nvm() {
|
||||
fi
|
||||
return 3
|
||||
# an exact, already-installed version needs no further resolution or checks
|
||||
elif [ "${NVM_USE_EXACT_INSTALLED}" -ne 1 ] && ! nvm_ensure_version_installed "${VERSION}" "${IS_VERSION_FROM_NVMRC}"; then
|
||||
return $?
|
||||
elif [ "${NVM_USE_EXACT_INSTALLED}" -ne 1 ]; then
|
||||
nvm_ensure_version_installed "${VERSION}" "${IS_VERSION_FROM_NVMRC}" || return $?
|
||||
fi
|
||||
|
||||
local NVM_VERSION_DIR
|
||||
|
||||
Reference in new issue
Block a user