eeymoo/nvm
1
0 Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-11-12 00:00:00 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Fix] nvm_find_up, nvm_find_project_dir: stop at a Windows drive root instead of looping forever

Browse Source 
With a Windows-style `$PWD` (e.g. `D:/Work`, as Git Bash inherits when launched
by a native Windows program), `${path_%/*}` stops changing at `D:`, so the walk
never ends and sourcing `nvm.sh` hangs. Stop when going up doesn't change the
path, which also covers the existing `.` case.

Fixes #3967.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_01RBGzjdkmgq6LSA7SFtjRsY
This commit is contained in:
Daniel OriyanandClaude Opus 5.5 authored and Jordan Harband committed 2026-10-23 13:54:04 +03:00
1 parent 13eee46e7d
commit ea84cb311e
3 files changed
+16 -4
Download Patch File Download Diff File Expand all files Collapse all files

No files matched your search

test/fast/Unit tests/nvm_find_project_dir
+3
View File
@@ -35,3 +35,6 @@ ACTUAL="$(PWD=$TEST_DIR/no-nesting-pkg nvm_find_project_dir)"
ACTUAL="$(PWD="." nvm_find_project_dir)"
[ "${ACTUAL}" = "." ] || die "insufficient permissions for pwd: got ${ACTUAL}"
ACTUAL="$(PWD="Q:/nonexistent/dir" nvm_find_project_dir)"
[ "${ACTUAL}" = "Q:" ] || die "Windows-style drive path from pwd: got ${ACTUAL}"
test/fast/Unit tests/nvm_find_up
+1
View File
@@ -23,5 +23,6 @@ TEST_DIR="$PWD"
[ "~$(PWD=$TEST_DIR/tmp_nvm_find_up/a/b/c nvm_find_up 'test')" = "~$TEST_DIR/tmp_nvm_find_up/a/b/c" ] || die "failed to find in current dir"
[ "~$(PWD=$TEST_DIR/tmp_nvm_find_up/a/b/c/d nvm_find_up 'test')" = "~$TEST_DIR/tmp_nvm_find_up/a/b/c" ] || die "failed to find 1 level up from current dir"
[ "~$(PWD="." nvm_find_up 'test')" = "~." ] || die "failed to handle '.' output from pwd"
[ "~$(PWD="Q:/nonexistent/dir" nvm_find_up 'test')" = "~Q:" ] || die "failed to handle Windows-style drive path from pwd"
cleanup