[Fix] nvm_remote_versions: only consult io.js's version list for majors 1 through 3
io.js only released v1 through v3, but its version list was downloaded and searched for every pattern, including ones like `0.12` or `20` that can only ever match node versions. Besides the needless index.tab download on every such `nvm install`, io.js's "no match" status was returned even when node had matches, so `nvm ls-remote 20` printed node's versions and then exited 3. Patterns whose major is 0 or 4+ now only consult node's list, so `nvm ls-remote` exits 0 for them when node has matching versions. The listed and resolved versions are unchanged Discovered by Anthropic's OSS Scanner, as ANT-2026-AKH0HYWD; the scanner reported it as a vulnerability, but it is not one.
This commit is contained in:
3 files changed
+41
No files matched your search
@@ -74,6 +74,7 @@ try nvm_remote_version node
|
||||
nvm_ls_remote() {
|
||||
case "${1-}" in
|
||||
20 | v20.0.0) echo "v20.0.0" ;;
|
||||
0.12) echo "v0.12.18" ;;
|
||||
*) echo "N/A"; return 3 ;;
|
||||
esac
|
||||
}
|
||||
@@ -86,6 +87,14 @@ for PATTERN in 20 v20.0.0; do
|
||||
[ "_$CAPTURED_EXIT_CODE" = "_0" ] || die "nvm_remote_version ${PATTERN} should exit with code 0, got $CAPTURED_EXIT_CODE"
|
||||
done
|
||||
|
||||
# io.js only released v1 through v3, so it is not consulted for any other major
|
||||
try nvm_remote_version 0.12
|
||||
[ "_$CAPTURED_STDOUT" = "_v0.12.18" ] || die "nvm_remote_version 0.12 should return v0.12.18, got $CAPTURED_STDOUT"
|
||||
[ "_$CAPTURED_EXIT_CODE" = "_0" ] || die "nvm_remote_version 0.12 should exit with code 0, got $CAPTURED_EXIT_CODE"
|
||||
try nvm_remote_version 99
|
||||
[ "_$CAPTURED_STDOUT" = "_N/A" ] || die "nvm_remote_version 99 should return N/A, got $CAPTURED_STDOUT"
|
||||
[ "_$CAPTURED_EXIT_CODE" = "_3" ] || die "nvm_remote_version 99 should exit with code 3, got $CAPTURED_EXIT_CODE"
|
||||
|
||||
# Test LTS name rejection (Issue #3474)
|
||||
# When nvm_remote_versions returns a line with LTS name in description,
|
||||
# nvm_remote_version should reject it if the pattern doesn't match the version number
|
||||
|
||||
Reference in new issue
Block a user