From 61c9ff73715b674c17adc5d22007d9487425b4b9 Mon Sep 17 00:00:00 2001 From: Jordan Harband Date: Wed, 3 Jun 2026 14:53:48 -0700 Subject: [PATCH] [Tests] `install_nvm_from_git`: fix malformed test command (missing space before `]`) `[ "${head_ref}" != "${avoid_ref}"]` is missing the space before the closing bracket, so the shell prints `[: missing ']'` and the avoid_ref assertion never actually runs (it is inside an `if` condition, so the error was non-fatal and silently disabled the check) --- test/install_script/install_nvm_from_git | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/test/install_script/install_nvm_from_git b/test/install_script/install_nvm_from_git index e5e391e6..4a89b592 100755 --- a/test/install_script/install_nvm_from_git +++ b/test/install_script/install_nvm_from_git @@ -61,7 +61,7 @@ test_install_data() { fi local head_ref="$(git for-each-ref --points-at HEAD --format='%(refname:short)' 'refs/tags/')" - if [ -n "${avoid_ref}" ] && [ "${head_ref}" != "${avoid_ref}"]; then + if [ -n "${avoid_ref}" ] && [ "${head_ref}" != "${avoid_ref}" ]; then echo "${current_ref}" | grep -q "$avoid_ref" && die "install_nvm_from_git ${message} did clone with unwanted ref ${avoid_ref}" fi