eeymoo/nvm
1
0
Fork 0
mirror of https://github.com/nvm-sh/nvm.git synced 2026-04-04 20:14:50 +08:00
Code Issues Actions Packages Projects Releases Wiki Activity

[Tests] fix 4 test failures

Browse Source 
- `nvm-exec` test: expect "Found .nvmrc" message in output, since `nvm_rc_version` now outputs it to stdout via fd 3 redirection (ef162036)
- `nvm_install_binary_nosource`: fix exit code capture by running the command directly instead of inside a subshell with `echo $?` (05d78477)
- `nvm_iojs_version_has_solaris_binary`: bare versions like `v3.3.1` (without `iojs-` prefix) are node versions and should be rejected. The old tests relied on the buggy comparison that let them through (53e6244a)
- `nvm_get_arch_unofficial`: copy `uname` into the chroot. The old test passed only because the unconditional `NVM_ARCH=x64-musl` masked the missing binary, but the `case` fix now requires a real arch to match (39e71eab)
This commit is contained in:
Jordan Harband
2026-03-24 12:44:21 -07:00
parent ae31eceecc
commit 3e37cfb9c4
4 changed files with 11 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

8
test/fast/Unit tests/nvm_iojs_version_has_solaris_binary
View File

@@ -14,9 +14,11 @@ assert_not_ok nvm_iojs_version_has_solaris_binary "v1.1.0"
assert_not_ok nvm_iojs_version_has_solaris_binary "v4.0.0"
assert_not_ok nvm_iojs_version_has_solaris_binary "v8.0.0"
assert_ok nvm_iojs_version_has_solaris_binary "v3.3.1"
# Bare versions without iojs- prefix are node versions, not iojs
assert_not_ok nvm_iojs_version_has_solaris_binary "v3.3.1"
assert_not_ok nvm_iojs_version_has_solaris_binary "v3.3.2"
assert_not_ok nvm_iojs_version_has_solaris_binary "v3.4.1"
assert_ok nvm_iojs_version_has_solaris_binary "iojs-v3.3.1"
assert_ok nvm_iojs_version_has_solaris_binary "v3.3.2"
assert_ok nvm_iojs_version_has_solaris_binary "iojs-v3.3.2"
assert_ok nvm_iojs_version_has_solaris_binary "v3.4.1"
assert_ok nvm_iojs_version_has_solaris_binary "iojs-v3.4.1"