Resolve claw-code main merge conflicts

This commit is contained in:
Yeachan-Heo
2026-04-06 05:46:52 +00:00
parent 01b263c838
commit f9cb42fb44
5 changed files with 939 additions and 22 deletions

View File

@@ -2977,6 +2977,244 @@ fn resolve_skill_path(skill: &str) -> Result<std::path::PathBuf, String> {
commands::resolve_skill_path(&cwd, skill).map_err(|error| error.to_string())
}
#[derive(Debug, Clone, Copy, PartialEq, Eq)]
enum SkillLookupOrigin {
SkillsDir,
LegacyCommandsDir,
}
#[derive(Debug, Clone, PartialEq, Eq)]
struct SkillLookupRoot {
path: std::path::PathBuf,
origin: SkillLookupOrigin,
}
fn skill_lookup_roots() -> Vec<SkillLookupRoot> {
let mut roots = Vec::new();
if let Ok(cwd) = std::env::current_dir() {
push_project_skill_lookup_roots(&mut roots, &cwd);
}
if let Ok(claw_config_home) = std::env::var("CLAW_CONFIG_HOME") {
push_prefixed_skill_lookup_roots(&mut roots, std::path::Path::new(&claw_config_home));
}
if let Ok(codex_home) = std::env::var("CODEX_HOME") {
push_prefixed_skill_lookup_roots(&mut roots, std::path::Path::new(&codex_home));
}
if let Ok(home) = std::env::var("HOME") {
push_home_skill_lookup_roots(&mut roots, std::path::Path::new(&home));
}
if let Ok(claude_config_dir) = std::env::var("CLAUDE_CONFIG_DIR") {
let claude_config_dir = std::path::PathBuf::from(claude_config_dir);
push_skill_lookup_root(
&mut roots,
claude_config_dir.join("skills"),
SkillLookupOrigin::SkillsDir,
);
push_skill_lookup_root(
&mut roots,
claude_config_dir.join("skills").join("omc-learned"),
SkillLookupOrigin::SkillsDir,
);
push_skill_lookup_root(
&mut roots,
claude_config_dir.join("commands"),
SkillLookupOrigin::LegacyCommandsDir,
);
}
push_skill_lookup_root(
&mut roots,
std::path::PathBuf::from("/home/bellman/.claw/skills"),
SkillLookupOrigin::SkillsDir,
);
push_skill_lookup_root(
&mut roots,
std::path::PathBuf::from("/home/bellman/.codex/skills"),
SkillLookupOrigin::SkillsDir,
);
roots
}
fn push_project_skill_lookup_roots(roots: &mut Vec<SkillLookupRoot>, cwd: &std::path::Path) {
for ancestor in cwd.ancestors() {
push_prefixed_skill_lookup_roots(roots, &ancestor.join(".omc"));
push_prefixed_skill_lookup_roots(roots, &ancestor.join(".agents"));
push_prefixed_skill_lookup_roots(roots, &ancestor.join(".claw"));
push_prefixed_skill_lookup_roots(roots, &ancestor.join(".codex"));
push_prefixed_skill_lookup_roots(roots, &ancestor.join(".claude"));
}
}
fn push_home_skill_lookup_roots(roots: &mut Vec<SkillLookupRoot>, home: &std::path::Path) {
push_prefixed_skill_lookup_roots(roots, &home.join(".omc"));
push_prefixed_skill_lookup_roots(roots, &home.join(".claw"));
push_prefixed_skill_lookup_roots(roots, &home.join(".codex"));
push_prefixed_skill_lookup_roots(roots, &home.join(".claude"));
push_skill_lookup_root(
roots,
home.join(".agents").join("skills"),
SkillLookupOrigin::SkillsDir,
);
push_skill_lookup_root(
roots,
home.join(".config").join("opencode").join("skills"),
SkillLookupOrigin::SkillsDir,
);
push_skill_lookup_root(
roots,
home.join(".claude").join("skills").join("omc-learned"),
SkillLookupOrigin::SkillsDir,
);
}
fn push_prefixed_skill_lookup_roots(roots: &mut Vec<SkillLookupRoot>, prefix: &std::path::Path) {
push_skill_lookup_root(roots, prefix.join("skills"), SkillLookupOrigin::SkillsDir);
push_skill_lookup_root(
roots,
prefix.join("commands"),
SkillLookupOrigin::LegacyCommandsDir,
);
}
fn push_skill_lookup_root(
roots: &mut Vec<SkillLookupRoot>,
path: std::path::PathBuf,
origin: SkillLookupOrigin,
) {
if path.is_dir() && !roots.iter().any(|existing| existing.path == path) {
roots.push(SkillLookupRoot { path, origin });
}
}
fn resolve_skill_path_in_root(
root: &SkillLookupRoot,
requested: &str,
) -> Option<std::path::PathBuf> {
match root.origin {
SkillLookupOrigin::SkillsDir => resolve_skill_path_in_skills_dir(&root.path, requested),
SkillLookupOrigin::LegacyCommandsDir => {
resolve_skill_path_in_legacy_commands_dir(&root.path, requested)
}
}
}
fn resolve_skill_path_in_skills_dir(
root: &std::path::Path,
requested: &str,
) -> Option<std::path::PathBuf> {
let direct = root.join(requested).join("SKILL.md");
if direct.is_file() {
return Some(direct);
}
let entries = std::fs::read_dir(root).ok()?;
for entry in entries.flatten() {
if !entry.path().is_dir() {
continue;
}
let skill_path = entry.path().join("SKILL.md");
if !skill_path.is_file() {
continue;
}
if entry
.file_name()
.to_string_lossy()
.eq_ignore_ascii_case(requested)
|| skill_frontmatter_name_matches(&skill_path, requested)
{
return Some(skill_path);
}
}
None
}
fn resolve_skill_path_in_legacy_commands_dir(
root: &std::path::Path,
requested: &str,
) -> Option<std::path::PathBuf> {
let direct_dir = root.join(requested).join("SKILL.md");
if direct_dir.is_file() {
return Some(direct_dir);
}
let direct_markdown = root.join(format!("{requested}.md"));
if direct_markdown.is_file() {
return Some(direct_markdown);
}
let entries = std::fs::read_dir(root).ok()?;
for entry in entries.flatten() {
let path = entry.path();
let candidate_path = if path.is_dir() {
let skill_path = path.join("SKILL.md");
if !skill_path.is_file() {
continue;
}
skill_path
} else if path
.extension()
.is_some_and(|ext| ext.to_string_lossy().eq_ignore_ascii_case("md"))
{
path
} else {
continue;
};
let matches_entry_name = candidate_path
.file_stem()
.is_some_and(|stem| stem.to_string_lossy().eq_ignore_ascii_case(requested))
|| entry
.file_name()
.to_string_lossy()
.trim_end_matches(".md")
.eq_ignore_ascii_case(requested);
if matches_entry_name || skill_frontmatter_name_matches(&candidate_path, requested) {
return Some(candidate_path);
}
}
None
}
fn skill_frontmatter_name_matches(path: &std::path::Path, requested: &str) -> bool {
std::fs::read_to_string(path)
.ok()
.and_then(|contents| parse_skill_name(&contents))
.is_some_and(|name| name.eq_ignore_ascii_case(requested))
}
fn parse_skill_name(contents: &str) -> Option<String> {
parse_skill_frontmatter_value(contents, "name")
}
fn parse_skill_frontmatter_value(contents: &str, key: &str) -> Option<String> {
let mut lines = contents.lines();
if lines.next().map(str::trim) != Some("---") {
return None;
}
for line in lines {
let trimmed = line.trim();
if trimmed == "---" {
break;
}
if let Some(value) = trimmed.strip_prefix(&format!("{key}:")) {
let value = value
.trim()
.trim_matches(|ch| matches!(ch, '"' | '\''))
.trim();
if !value.is_empty() {
return Some(value.to_string());
}
}
}
None
}
const DEFAULT_AGENT_MODEL: &str = "claude-opus-4-6";
const DEFAULT_AGENT_SYSTEM_DATE: &str = "2026-03-31";
const DEFAULT_AGENT_MAX_ITERATIONS: usize = 32;
@@ -5796,6 +6034,305 @@ mod tests {
fs::remove_dir_all(root).expect("temp project should clean up");
}
#[test]
fn skill_loads_project_local_claude_skill_prompt() {
let _guard = env_lock().lock().expect("env lock should acquire");
let root = temp_path("project-skills");
let home = root.join("home");
let workspace = root.join("workspace");
let nested = workspace.join("nested");
let skill_dir = workspace.join(".claude").join("skills").join("trace");
fs::create_dir_all(&skill_dir).expect("skill dir should exist");
fs::create_dir_all(&nested).expect("nested cwd should exist");
fs::write(
skill_dir.join("SKILL.md"),
"---\nname: trace\ndescription: Project-local trace helper\n---\n# trace\n",
)
.expect("skill file should exist");
let original_home = std::env::var("HOME").ok();
let original_config_home = std::env::var("CLAW_CONFIG_HOME").ok();
let original_codex_home = std::env::var("CODEX_HOME").ok();
let original_dir = std::env::current_dir().expect("cwd");
std::env::set_var("HOME", &home);
std::env::remove_var("CLAW_CONFIG_HOME");
std::env::remove_var("CODEX_HOME");
std::env::set_current_dir(&nested).expect("set cwd");
let result = execute_tool("Skill", &json!({ "skill": "trace" }))
.expect("project-local skill should resolve");
let output: serde_json::Value = serde_json::from_str(&result).expect("valid json");
assert!(output["path"]
.as_str()
.expect("path")
.ends_with(".claude/skills/trace/SKILL.md"));
assert_eq!(output["description"], "Project-local trace helper");
std::env::set_current_dir(&original_dir).expect("restore cwd");
match original_home {
Some(value) => std::env::set_var("HOME", value),
None => std::env::remove_var("HOME"),
}
match original_config_home {
Some(value) => std::env::set_var("CLAW_CONFIG_HOME", value),
None => std::env::remove_var("CLAW_CONFIG_HOME"),
}
match original_codex_home {
Some(value) => std::env::set_var("CODEX_HOME", value),
None => std::env::remove_var("CODEX_HOME"),
}
fs::remove_dir_all(root).expect("temp tree should clean up");
}
#[test]
fn skill_loads_project_local_omc_and_agents_skill_prompts() {
let _guard = env_lock().lock().expect("env lock should acquire");
let root = temp_path("project-omc-skills");
let home = root.join("home");
let workspace = root.join("workspace");
let nested = workspace.join("nested");
let omc_skill_dir = workspace.join(".omc").join("skills").join("hud");
let agents_skill_dir = workspace.join(".agents").join("skills").join("trace");
fs::create_dir_all(&omc_skill_dir).expect("omc skill dir should exist");
fs::create_dir_all(&agents_skill_dir).expect("agents skill dir should exist");
fs::create_dir_all(&nested).expect("nested cwd should exist");
fs::write(
omc_skill_dir.join("SKILL.md"),
"---\nname: hud\ndescription: Project-local OMC HUD helper\n---\n# hud\n",
)
.expect("omc skill file should exist");
fs::write(
agents_skill_dir.join("SKILL.md"),
"---\nname: trace\ndescription: Project-local agents compatibility helper\n---\n# trace\n",
)
.expect("agents skill file should exist");
let original_home = std::env::var("HOME").ok();
let original_config_home = std::env::var("CLAW_CONFIG_HOME").ok();
let original_codex_home = std::env::var("CODEX_HOME").ok();
let original_dir = std::env::current_dir().expect("cwd");
std::env::set_var("HOME", &home);
std::env::remove_var("CLAW_CONFIG_HOME");
std::env::remove_var("CODEX_HOME");
std::env::set_current_dir(&nested).expect("set cwd");
let omc_result =
execute_tool("Skill", &json!({ "skill": "hud" })).expect("omc skill should resolve");
let agents_result = execute_tool("Skill", &json!({ "skill": "trace" }))
.expect("agents skill should resolve");
let omc_output: serde_json::Value = serde_json::from_str(&omc_result).expect("valid json");
let agents_output: serde_json::Value =
serde_json::from_str(&agents_result).expect("valid json");
assert!(omc_output["path"]
.as_str()
.expect("path")
.ends_with(".omc/skills/hud/SKILL.md"));
assert_eq!(omc_output["description"], "Project-local OMC HUD helper");
assert!(agents_output["path"]
.as_str()
.expect("path")
.ends_with(".agents/skills/trace/SKILL.md"));
assert_eq!(
agents_output["description"],
"Project-local agents compatibility helper"
);
std::env::set_current_dir(&original_dir).expect("restore cwd");
match original_home {
Some(value) => std::env::set_var("HOME", value),
None => std::env::remove_var("HOME"),
}
match original_config_home {
Some(value) => std::env::set_var("CLAW_CONFIG_HOME", value),
None => std::env::remove_var("CLAW_CONFIG_HOME"),
}
match original_codex_home {
Some(value) => std::env::set_var("CODEX_HOME", value),
None => std::env::remove_var("CODEX_HOME"),
}
fs::remove_dir_all(root).expect("temp tree should clean up");
}
#[test]
fn skill_loads_learned_skill_from_claude_config_dir() {
let _guard = env_lock().lock().expect("env lock should acquire");
let root = temp_path("claude-config-learned-skill");
let home = root.join("home");
let claude_config_dir = root.join("claude-config");
let learned_skill_dir = claude_config_dir
.join("skills")
.join("omc-learned")
.join("learned");
fs::create_dir_all(&learned_skill_dir).expect("learned skill dir should exist");
fs::write(
learned_skill_dir.join("SKILL.md"),
"---\nname: learned\ndescription: Learned OMC skill\n---\n# learned\n",
)
.expect("learned skill file should exist");
let original_home = std::env::var("HOME").ok();
let original_config_home = std::env::var("CLAW_CONFIG_HOME").ok();
let original_codex_home = std::env::var("CODEX_HOME").ok();
let original_claude_config_dir = std::env::var("CLAUDE_CONFIG_DIR").ok();
std::env::set_var("HOME", &home);
std::env::remove_var("CLAW_CONFIG_HOME");
std::env::remove_var("CODEX_HOME");
std::env::set_var("CLAUDE_CONFIG_DIR", &claude_config_dir);
let result = execute_tool("Skill", &json!({ "skill": "learned" }))
.expect("learned skill should resolve");
let output: serde_json::Value = serde_json::from_str(&result).expect("valid json");
assert!(output["path"]
.as_str()
.expect("path")
.ends_with("skills/omc-learned/learned/SKILL.md"));
assert_eq!(output["description"], "Learned OMC skill");
match original_home {
Some(value) => std::env::set_var("HOME", value),
None => std::env::remove_var("HOME"),
}
match original_config_home {
Some(value) => std::env::set_var("CLAW_CONFIG_HOME", value),
None => std::env::remove_var("CLAW_CONFIG_HOME"),
}
match original_codex_home {
Some(value) => std::env::set_var("CODEX_HOME", value),
None => std::env::remove_var("CODEX_HOME"),
}
match original_claude_config_dir {
Some(value) => std::env::set_var("CLAUDE_CONFIG_DIR", value),
None => std::env::remove_var("CLAUDE_CONFIG_DIR"),
}
fs::remove_dir_all(root).expect("temp tree should clean up");
}
#[test]
fn skill_loads_direct_skill_and_legacy_command_from_claude_config_dir() {
let _guard = env_lock().lock().expect("env lock should acquire");
let root = temp_path("claude-config-direct-skill");
let home = root.join("home");
let claude_config_dir = root.join("claude-config");
let skill_dir = claude_config_dir.join("skills").join("statusline");
let command_dir = claude_config_dir.join("commands");
fs::create_dir_all(&skill_dir).expect("direct skill dir should exist");
fs::create_dir_all(&command_dir).expect("command dir should exist");
fs::write(
skill_dir.join("SKILL.md"),
"---\nname: statusline\ndescription: Claude config skill\n---\n# statusline\n",
)
.expect("direct skill file should exist");
fs::write(
command_dir.join("doctor-check.md"),
"---\nname: doctor-check\ndescription: Claude config command\n---\n# doctor-check\n",
)
.expect("direct command file should exist");
let original_home = std::env::var("HOME").ok();
let original_config_home = std::env::var("CLAW_CONFIG_HOME").ok();
let original_codex_home = std::env::var("CODEX_HOME").ok();
let original_claude_config_dir = std::env::var("CLAUDE_CONFIG_DIR").ok();
std::env::set_var("HOME", &home);
std::env::remove_var("CLAW_CONFIG_HOME");
std::env::remove_var("CODEX_HOME");
std::env::set_var("CLAUDE_CONFIG_DIR", &claude_config_dir);
let direct_skill =
execute_tool("Skill", &json!({ "skill": "statusline" })).expect("direct skill");
let direct_skill_output: serde_json::Value =
serde_json::from_str(&direct_skill).expect("valid skill json");
assert!(direct_skill_output["path"]
.as_str()
.expect("path")
.ends_with("skills/statusline/SKILL.md"));
assert_eq!(direct_skill_output["description"], "Claude config skill");
let legacy_command =
execute_tool("Skill", &json!({ "skill": "doctor-check" })).expect("direct command");
let legacy_command_output: serde_json::Value =
serde_json::from_str(&legacy_command).expect("valid command json");
assert!(legacy_command_output["path"]
.as_str()
.expect("path")
.ends_with("commands/doctor-check.md"));
assert_eq!(
legacy_command_output["description"],
"Claude config command"
);
match original_home {
Some(value) => std::env::set_var("HOME", value),
None => std::env::remove_var("HOME"),
}
match original_config_home {
Some(value) => std::env::set_var("CLAW_CONFIG_HOME", value),
None => std::env::remove_var("CLAW_CONFIG_HOME"),
}
match original_codex_home {
Some(value) => std::env::set_var("CODEX_HOME", value),
None => std::env::remove_var("CODEX_HOME"),
}
match original_claude_config_dir {
Some(value) => std::env::set_var("CLAUDE_CONFIG_DIR", value),
None => std::env::remove_var("CLAUDE_CONFIG_DIR"),
}
fs::remove_dir_all(root).expect("temp tree should clean up");
}
#[test]
fn skill_loads_project_local_legacy_command_markdown() {
let _guard = env_lock().lock().expect("env lock should acquire");
let root = temp_path("project-legacy-command");
let home = root.join("home");
let workspace = root.join("workspace");
let nested = workspace.join("nested");
let command_dir = workspace.join(".claude").join("commands");
fs::create_dir_all(&command_dir).expect("legacy command dir should exist");
fs::create_dir_all(&nested).expect("nested cwd should exist");
fs::write(
command_dir.join("team.md"),
"---\nname: team\ndescription: Legacy team workflow\n---\n# team\n",
)
.expect("legacy command file should exist");
let original_home = std::env::var("HOME").ok();
let original_config_home = std::env::var("CLAW_CONFIG_HOME").ok();
let original_codex_home = std::env::var("CODEX_HOME").ok();
let original_dir = std::env::current_dir().expect("cwd");
std::env::set_var("HOME", &home);
std::env::remove_var("CLAW_CONFIG_HOME");
std::env::remove_var("CODEX_HOME");
std::env::set_current_dir(&nested).expect("set cwd");
let result = execute_tool("Skill", &json!({ "skill": "team" }))
.expect("legacy command markdown should resolve");
let output: serde_json::Value = serde_json::from_str(&result).expect("valid json");
assert!(output["path"]
.as_str()
.expect("path")
.ends_with(".claude/commands/team.md"));
assert_eq!(output["description"], "Legacy team workflow");
std::env::set_current_dir(&original_dir).expect("restore cwd");
match original_home {
Some(value) => std::env::set_var("HOME", value),
None => std::env::remove_var("HOME"),
}
match original_config_home {
Some(value) => std::env::set_var("CLAW_CONFIG_HOME", value),
None => std::env::remove_var("CLAW_CONFIG_HOME"),
}
match original_codex_home {
Some(value) => std::env::set_var("CODEX_HOME", value),
None => std::env::remove_var("CODEX_HOME"),
}
fs::remove_dir_all(root).expect("temp tree should clean up");
}
#[test]
fn tool_search_supports_keyword_and_select_queries() {
let keyword = execute_tool(