mirror of
https://github.com/instructkr/claw-code.git
synced 2026-04-06 16:14:49 +08:00
Merge remote-tracking branch 'origin/rcc/jsonl-session' into integration/dori-cleanroom
# Conflicts: # rust/crates/commands/src/lib.rs # rust/crates/runtime/src/lib.rs # rust/crates/rusty-claude-cli/src/main.rs
This commit is contained in:
@@ -267,8 +267,8 @@ where
|
||||
mut prompter: Option<&mut dyn PermissionPrompter>,
|
||||
) -> Result<TurnSummary, RuntimeError> {
|
||||
self.session
|
||||
.messages
|
||||
.push(ConversationMessage::user_text(user_input.into()));
|
||||
.push_user_text(user_input.into())
|
||||
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||
|
||||
let mut assistant_messages = Vec::new();
|
||||
let mut tool_results = Vec::new();
|
||||
@@ -302,7 +302,9 @@ where
|
||||
})
|
||||
.collect::<Vec<_>>();
|
||||
|
||||
self.session.messages.push(assistant_message.clone());
|
||||
self.session
|
||||
.push_message(assistant_message.clone())
|
||||
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||
assistant_messages.push(assistant_message);
|
||||
|
||||
if pending_tool_uses.is_empty() {
|
||||
@@ -390,7 +392,9 @@ where
|
||||
true,
|
||||
),
|
||||
};
|
||||
self.session.messages.push(result_message.clone());
|
||||
self.session
|
||||
.push_message(result_message.clone())
|
||||
.map_err(|error| RuntimeError::new(error.to_string()))?;
|
||||
tool_results.push(result_message);
|
||||
}
|
||||
}
|
||||
@@ -426,6 +430,11 @@ where
|
||||
&self.session
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn fork_session(&self, branch_name: Option<String>) -> Session {
|
||||
self.session.fork(branch_name)
|
||||
}
|
||||
|
||||
#[must_use]
|
||||
pub fn into_session(self) -> Session {
|
||||
self.session
|
||||
@@ -595,7 +604,9 @@ mod tests {
|
||||
use crate::prompt::{ProjectContext, SystemPromptBuilder};
|
||||
use crate::session::{ContentBlock, MessageRole, Session};
|
||||
use crate::usage::TokenUsage;
|
||||
use std::fs;
|
||||
use std::path::PathBuf;
|
||||
use std::time::{SystemTime, UNIX_EPOCH};
|
||||
|
||||
struct ScriptedApiClient {
|
||||
call_count: usize,
|
||||
@@ -977,6 +988,86 @@ mod tests {
|
||||
result.compacted_session.messages[0].role,
|
||||
MessageRole::System
|
||||
);
|
||||
assert_eq!(
|
||||
result.compacted_session.session_id,
|
||||
runtime.session().session_id
|
||||
);
|
||||
assert!(result.compacted_session.compaction.is_some());
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn persists_conversation_turn_messages_to_jsonl_session() {
|
||||
struct SimpleApi;
|
||||
impl ApiClient for SimpleApi {
|
||||
fn stream(
|
||||
&mut self,
|
||||
_request: ApiRequest,
|
||||
) -> Result<Vec<AssistantEvent>, RuntimeError> {
|
||||
Ok(vec![
|
||||
AssistantEvent::TextDelta("done".to_string()),
|
||||
AssistantEvent::MessageStop,
|
||||
])
|
||||
}
|
||||
}
|
||||
|
||||
let path = temp_session_path("persisted-turn");
|
||||
let session = Session::new().with_persistence_path(path.clone());
|
||||
let mut runtime = ConversationRuntime::new(
|
||||
session,
|
||||
SimpleApi,
|
||||
StaticToolExecutor::new(),
|
||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||
vec!["system".to_string()],
|
||||
);
|
||||
|
||||
runtime
|
||||
.run_turn("persist this turn", None)
|
||||
.expect("turn should succeed");
|
||||
|
||||
let restored = Session::load_from_path(&path).expect("persisted session should reload");
|
||||
fs::remove_file(&path).expect("temp session file should be removable");
|
||||
|
||||
assert_eq!(restored.messages.len(), 2);
|
||||
assert_eq!(restored.messages[0].role, MessageRole::User);
|
||||
assert_eq!(restored.messages[1].role, MessageRole::Assistant);
|
||||
assert_eq!(restored.session_id, runtime.session().session_id);
|
||||
}
|
||||
|
||||
#[test]
|
||||
fn forks_runtime_session_without_mutating_original() {
|
||||
let mut session = Session::new();
|
||||
session
|
||||
.push_user_text("branch me")
|
||||
.expect("message should append");
|
||||
|
||||
let runtime = ConversationRuntime::new(
|
||||
session.clone(),
|
||||
ScriptedApiClient { call_count: 0 },
|
||||
StaticToolExecutor::new(),
|
||||
PermissionPolicy::new(PermissionMode::DangerFullAccess),
|
||||
vec!["system".to_string()],
|
||||
);
|
||||
|
||||
let forked = runtime.fork_session(Some("alt-path".to_string()));
|
||||
|
||||
assert_eq!(forked.messages, session.messages);
|
||||
assert_ne!(forked.session_id, session.session_id);
|
||||
assert_eq!(
|
||||
forked
|
||||
.fork
|
||||
.as_ref()
|
||||
.map(|fork| (fork.parent_session_id.as_str(), fork.branch_name.as_deref())),
|
||||
Some((session.session_id.as_str(), Some("alt-path")))
|
||||
);
|
||||
assert!(runtime.session().fork.is_none());
|
||||
}
|
||||
|
||||
fn temp_session_path(label: &str) -> PathBuf {
|
||||
let nanos = SystemTime::now()
|
||||
.duration_since(UNIX_EPOCH)
|
||||
.expect("system time should be after epoch")
|
||||
.as_nanos();
|
||||
std::env::temp_dir().join(format!("runtime-conversation-{label}-{nanos}.json"))
|
||||
}
|
||||
|
||||
#[cfg(windows)]
|
||||
|
||||
Reference in New Issue
Block a user