From 110d568bcf1dc23dcbfd45f577e87bf89da1948d Mon Sep 17 00:00:00 2001
From: Yeachan-Heo <hurrc04@gmail.com>
Date: Thu, 16 Apr 2026 10:12:36 +0000
Subject: [PATCH] Mark US-008 complete: kimi-k2.5 API compatibility fix

- translate_message now conditionally includes is_error field
- kimi models (kimi-k2.5, kimi-k1.5, etc.) exclude is_error
- Other models (openai, grok, xai) keep is_error support
---
 prd.json | 17 +++++++++++++++++
 1 file changed, 17 insertions(+)

diff --git a/prd.json b/prd.json
index 5b0cc29..890fe45 100644
--- a/prd.json
+++ b/prd.json
@@ -99,6 +99,23 @@
       ],
       "passes": true,
       "priority": "P2"
+    },
+    {
+      "id": "US-008",
+      "title": "Fix kimi-k2.5 model API compatibility",
+      "description": "The kimi-k2.5 model (and other kimi models) reject API requests containing the is_error field in tool result messages. The OpenAI-compatible provider currently always includes is_error for all models. Need to make this field conditional based on model support.",
+      "acceptanceCriteria": [
+        "translate_message function accepts model parameter",
+        "is_error field excluded for kimi models (kimi-k2.5, kimi-k1.5, etc.)",
+        "is_error field included for models that support it (openai, grok, xai, etc.)",
+        "build_chat_completion_request passes model to translate_message",
+        "Tests verify is_error presence/absence based on model",
+        "cargo test passes",
+        "cargo clippy passes",
+        "cargo fmt passes"
+      ],
+      "passes": true,
+      "priority": "P0"
     }
   ]
 }